Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 132333019: Use `CHECK_OBJECT_COERCIBLE` macro where possible (Closed)

Created:
6 years, 10 months ago by mathias
Modified:
6 years, 10 months ago
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Use `CHECK_OBJECT_COERCIBLE` macro where possible Contributed by Mathias Bynens <mathiasb@opera.com>;. TEST= BUG=v8:3122 LOG=N R=arv@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18979

Patch Set 1 #

Patch Set 2 : Don’t update copyright year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -92 lines) Patch
M src/array.js View 1 19 chunks +19 lines, -76 lines 0 comments Download
M src/harmony-array.js View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/v8natives.js View 1 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jakob Kummerow
Drive-by comments: - we generally don't update copyright years any more - LOG=Y is for ...
6 years, 10 months ago (2014-01-29 09:15:15 UTC) #1
mathias
On 2014/01/29 09:15:15, Jakob wrote: > Drive-by comments: […] Thanks for the tips! Updated the ...
6 years, 10 months ago (2014-01-29 09:23:05 UTC) #2
arv (Not doing code reviews)
LGTM I'm not a committer so I'm adding Jakob as a reviewer. Someone on the ...
6 years, 10 months ago (2014-01-30 04:25:52 UTC) #3
mathiasb
> I'm not a committer so I'm adding Jakob as a reviewer. Someone on the ...
6 years, 10 months ago (2014-01-30 07:20:07 UTC) #4
Benedikt Meurer
LGTM, I'll land it.
6 years, 10 months ago (2014-01-31 10:05:34 UTC) #5
Benedikt Meurer
6 years, 10 months ago (2014-01-31 10:06:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r18979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698