Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 132333002: Fix Mac fontconfig build (try 2) (Closed)

Created:
6 years, 11 months ago by vandebo (ex-Chrome)
Modified:
6 years, 11 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix Mac fontconfig build (try 2) The Mac fontconfig just #defines the cache directory, which works fine if fontconfig never has to look up any fonts (the case until now). If it has to actually find fonts from the disk, the cache directory and config directory need to be properly defined as well as running fc-cache to populate the cache directory. Populating the cache directory can take some time, but should only happen on a clean build. To remove this extra time, we have to not build poppler on Mac, which can now be accomplished with GYP_DEFINES="skia_mac_poppler=0" Committed: http://code.google.com/p/skia/source/detail?r=13007

Patch Set 1 #

Patch Set 2 : argparse -> optparse for OSX 10.6 #

Total comments: 4

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -367 lines) Patch
M gyp/common_variables.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M gyp/fontconfig.gyp View 3 chunks +103 lines, -4 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/fontconfig/README.chromium View 1 chunk +8 lines, -3 lines 0 comments Download
D third_party/fontconfig/config/mac/config.h View 1 chunk +0 lines, -358 lines 0 comments Download
A + third_party/fontconfig/config/mac/config.h.template View 2 chunks +5 lines, -1 line 0 comments Download
A third_party/fontconfig/process-template.py View 1 2 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
6 years, 11 months ago (2014-01-09 18:35:31 UTC) #1
epoger
https://codereview.chromium.org/132333002/diff/30001/third_party/fontconfig/process-template.py File third_party/fontconfig/process-template.py (right): https://codereview.chromium.org/132333002/diff/30001/third_party/fontconfig/process-template.py#newcode1 third_party/fontconfig/process-template.py:1: #!/usr/bin/python Do the broken Trybot runs indicate a real ...
6 years, 11 months ago (2014-01-09 18:42:42 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/132333002/diff/30001/third_party/fontconfig/process-template.py File third_party/fontconfig/process-template.py (right): https://codereview.chromium.org/132333002/diff/30001/third_party/fontconfig/process-template.py#newcode1 third_party/fontconfig/process-template.py:1: #!/usr/bin/python On 2014/01/09 18:42:42, epoger wrote: > Do the ...
6 years, 11 months ago (2014-01-09 19:24:32 UTC) #3
epoger
lgtm
6 years, 11 months ago (2014-01-09 19:26:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/132333002/100001
6 years, 11 months ago (2014-01-09 22:45:52 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 22:54:30 UTC) #6
Message was sent while issue was closed.
Change committed as 13007

Powered by Google App Engine
This is Rietveld 408576698