Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: Source/modules/indexeddb/IDBRequest.h

Issue 1323323002: IndexedDB: Various C++11isms and cleanup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: True, false, whatever Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBRequest.h
diff --git a/Source/modules/indexeddb/IDBRequest.h b/Source/modules/indexeddb/IDBRequest.h
index 312b62c9345de500cb9c679f7b3498f76612d78d..6c5e1eece54f06caa237689fabc69d574c876ad5 100644
--- a/Source/modules/indexeddb/IDBRequest.h
+++ b/Source/modules/indexeddb/IDBRequest.h
@@ -136,10 +136,10 @@ protected:
// EventTarget
bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) override;
- bool m_contextStopped;
+ bool m_contextStopped = false;
Member<IDBTransaction> m_transaction;
- ReadyState m_readyState;
- bool m_requestAborted; // May be aborted by transaction then receive async onsuccess; ignore vs. assert.
+ ReadyState m_readyState = PENDING;
+ bool m_requestAborted = false; // May be aborted by transaction then receive async onsuccess; ignore vs. assert.
private:
void setResultCursor(IDBCursor*, IDBKey*, IDBKey* primaryKey, PassRefPtr<IDBValue>);
@@ -151,12 +151,12 @@ private:
Member<IDBAny> m_result;
Member<DOMError> m_error;
- bool m_hasPendingActivity;
+ bool m_hasPendingActivity = true;
WillBeHeapVector<RefPtrWillBeMember<Event>> m_enqueuedEvents;
// Only used if the result type will be a cursor.
- IndexedDB::CursorType m_cursorType;
- WebIDBCursorDirection m_cursorDirection;
+ IndexedDB::CursorType m_cursorType = IndexedDB::CursorKeyAndValue;
+ WebIDBCursorDirection m_cursorDirection = WebIDBCursorDirectionNext;
// When a cursor is continued/advanced, m_result is cleared and m_pendingCursor holds it.
Member<IDBCursor> m_pendingCursor;
cmumford 2015/09/03 23:21:03 The constructor initialized this to nullptr - I'm
jsbell 2015/09/03 23:29:54 Right - it was a raw pointer at one point, not nee
// New state is not applied to the cursor object until the event is dispatched.
@@ -164,9 +164,9 @@ private:
Member<IDBKey> m_cursorPrimaryKey;
RefPtr<IDBValue> m_cursorValue;
- bool m_didFireUpgradeNeededEvent;
- bool m_preventPropagation;
- bool m_resultDirty;
+ bool m_didFireUpgradeNeededEvent = false;
+ bool m_preventPropagation = false;
+ bool m_resultDirty = true;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698