IndexedDB: Various C++11isms and cleanup

Source/modules/indexeddb/IDBRequest.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 118 matching lines @@
     IDBRequest(ScriptState*, IDBAny* source, IDBTransaction*);
     void enqueueEvent(PassRefPtrWillBeRawPtr<Event>);
     void dequeueEvent(Event*);
     virtual bool shouldEnqueueEvent() const;
     void onSuccessInternal(IDBAny*);
     void setResult(IDBAny*);
 
     // EventTarget
     bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) override;
 
-    bool m_contextStopped;
+    bool m_contextStopped = false;
     Member<IDBTransaction> m_transaction;
-    ReadyState m_readyState;
-    bool m_requestAborted; // May be aborted by transaction then receive async onsuccess; ignore vs. assert.
+    ReadyState m_readyState = PENDING;
+    bool m_requestAborted = false; // May be aborted by transaction then receive async onsuccess; ignore vs. assert.
 
 private:
     void setResultCursor(IDBCursor*, IDBKey*, IDBKey* primaryKey, PassRefPtr<IDBValue>);
     void ackReceivedBlobs(const IDBValue*);
     void ackReceivedBlobs(const Vector<RefPtr<IDBValue>>&);
 
     RefPtr<ScriptState> m_scriptState;
     Member<IDBAny> m_source;
     Member<IDBAny> m_result;
     Member<DOMError> m_error;
 
-    bool m_hasPendingActivity;
+    bool m_hasPendingActivity = true;
     WillBeHeapVector<RefPtrWillBeMember<Event>> m_enqueuedEvents;
 
     // Only used if the result type will be a cursor.
-    IndexedDB::CursorType m_cursorType;
-    WebIDBCursorDirection m_cursorDirection;
+    IndexedDB::CursorType m_cursorType = IndexedDB::CursorKeyAndValue;
+    WebIDBCursorDirection m_cursorDirection = WebIDBCursorDirectionNext;
     // When a cursor is continued/advanced, m_result is cleared and m_pendingCursor holds it.
     Member<IDBCursor> m_pendingCursor;

[cmumford, 2015/09/03 23:21:03]

The constructor initialized this to nullptr - I'm guessing that was redundant.

[jsbell, 2015/09/03 23:29:54]

Right - it was a raw pointer at one point, not needed for Member<>

     // New state is not applied to the cursor object until the event is dispatched.
     Member<IDBKey> m_cursorKey;
     Member<IDBKey> m_cursorPrimaryKey;
     RefPtr<IDBValue> m_cursorValue;
 
-    bool m_didFireUpgradeNeededEvent;
-    bool m_preventPropagation;
-    bool m_resultDirty;
+    bool m_didFireUpgradeNeededEvent = false;
+    bool m_preventPropagation = false;
+    bool m_resultDirty = true;
 };
 
 } // namespace blink
 
 #endif // IDBRequest_h