Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: Source/devtools/front_end/sdk/NetworkManager.js

Issue 1323273002: Ignore blank origins in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Move to the model level. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/Source/devtools/front_end/sdk/NetworkManager.js b/Source/devtools/front_end/sdk/NetworkManager.js
index 29ab862de358d7f186b0d3d951041954ed03252a..fdcf470bf74af88d898f0d959e5681eeff55cd99 100644
--- a/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/Source/devtools/front_end/sdk/NetworkManager.js
@@ -362,9 +362,15 @@ WebInspector.NetworkDispatcher.prototype = {
*/
_dispatchResponseReceivedSecurityDetails: function(requestId, response)
{
+ var origin = WebInspector.ParsedURL.splitURLIntoPathComponents(response.url)[0];
dgozman 2015/09/03 21:01:16 Side note: do you need to include port here? If so
+ if (!origin) {
+ // We don't handle resources like data: URIs. Most of them don't affect the lock icon.
+ return;
+ }
+
var eventData = {};
eventData.requestId = requestId;
- eventData.origin = WebInspector.ParsedURL.splitURLIntoPathComponents(response.url)[0];
+ eventData.origin = origin;
eventData.securityState = response.securityState;
if (response.securityDetails) {
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698