Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: Source/devtools/front_end/security/SecurityPanel.js

Issue 1323273002: Ignore blank origins in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/security/SecurityPanel.js
diff --git a/Source/devtools/front_end/security/SecurityPanel.js b/Source/devtools/front_end/security/SecurityPanel.js
index da81c396a25dcdd2ada438246bc08a45af1dd923..aa52557394e461084dd719bf43d384b8361b3576 100644
--- a/Source/devtools/front_end/security/SecurityPanel.js
+++ b/Source/devtools/front_end/security/SecurityPanel.js
@@ -124,6 +124,11 @@ WebInspector.SecurityPanel.prototype = {
var origin = /** @type {string} */ (data.origin);
var securityState = /** @type {!SecurityAgent.SecurityState} */ (data.securityState);
+ if (origin === "") {
dgozman 2015/09/03 20:12:18 if (!origin)
+ // We don't handle resources like data: URIs yet. Most of them don't affect the lock icon, anyhow.
+ return;
dgozman 2015/09/03 20:12:18 You should this on the model level, not on present
lgarron 2015/09/03 20:36:31 Hmm, that feels like it goes against the advice I
+ }
+
if (this._origins.has(origin)) {
var originState = this._origins.get(origin);
var oldSecurityState = originState.securityState;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698