Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323273002: Ignore blank origins in the Security panel. (Closed)

Created:
5 years, 3 months ago by lgarron
Modified:
5 years, 3 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ignore blank origins in the Security panel. BUG=525334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201745

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move to the model level. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/devtools/front_end/sdk/NetworkManager.js View 1 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 12 (4 generated)
lgarron
dgozman@: Could you review?
5 years, 3 months ago (2015-09-03 02:37:26 UTC) #2
dgozman
https://codereview.chromium.org/1323273002/diff/1/Source/devtools/front_end/security/SecurityPanel.js File Source/devtools/front_end/security/SecurityPanel.js (right): https://codereview.chromium.org/1323273002/diff/1/Source/devtools/front_end/security/SecurityPanel.js#newcode127 Source/devtools/front_end/security/SecurityPanel.js:127: if (origin === "") { if (!origin) https://codereview.chromium.org/1323273002/diff/1/Source/devtools/front_end/security/SecurityPanel.js#newcode129 Source/devtools/front_end/security/SecurityPanel.js:129: ...
5 years, 3 months ago (2015-09-03 20:12:19 UTC) #3
lgarron
https://codereview.chromium.org/1323273002/diff/1/Source/devtools/front_end/security/SecurityPanel.js File Source/devtools/front_end/security/SecurityPanel.js (right): https://codereview.chromium.org/1323273002/diff/1/Source/devtools/front_end/security/SecurityPanel.js#newcode129 Source/devtools/front_end/security/SecurityPanel.js:129: return; On 2015/09/03 at 20:12:18, dgozman wrote: > You ...
5 years, 3 months ago (2015-09-03 20:36:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323273002/20001
5 years, 3 months ago (2015-09-03 20:55:34 UTC) #6
dgozman
lgtm https://codereview.chromium.org/1323273002/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/1323273002/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js#newcode365 Source/devtools/front_end/sdk/NetworkManager.js:365: var origin = WebInspector.ParsedURL.splitURLIntoPathComponents(response.url)[0]; Side note: do you ...
5 years, 3 months ago (2015-09-03 21:01:16 UTC) #7
lgarron
On 2015/09/03 at 21:01:16, dgozman wrote: > lgtm > > https://codereview.chromium.org/1323273002/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js > File Source/devtools/front_end/sdk/NetworkManager.js (right): ...
5 years, 3 months ago (2015-09-03 21:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323273002/20001
5 years, 3 months ago (2015-09-03 21:05:30 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 22:09:03 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201745

Powered by Google App Engine
This is Rietveld 408576698