Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1323263004: Do not trigger action mode actions after being destroyed. (Closed)

Created:
5 years, 3 months ago by Ted C
Modified:
5 years, 3 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not trigger action mode actions after being destroyed. After calling destroy on the action mode, you can still click on the view as it is being torn down. This can cause you to call methods on a defunct CVC in certain cases causing a crash. To work around this, track if destroy has been called and stop calling our handler in that case. BUG=525365 Committed: https://crrev.com/9d19f85316095d9fac5ecf0a507b2270f1d04e90 Cr-Commit-Position: refs/heads/master@{#347298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years, 3 months ago (2015-09-03 22:48:41 UTC) #2
jdduke (slow)
On 2015/09/03 22:48:41, Ted C wrote: > PTAL Scary, lgtm.
5 years, 3 months ago (2015-09-03 22:52:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323263004/1
5 years, 3 months ago (2015-09-04 00:01:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 01:03:18 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 01:04:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d19f85316095d9fac5ecf0a507b2270f1d04e90
Cr-Commit-Position: refs/heads/master@{#347298}

Powered by Google App Engine
This is Rietveld 408576698