Security panel origin view: truncate SAN to two entries by default.

Security panel origin view: truncate SAN to two entries by default.

Also add a link to toggle the full list.

BUG=523591
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201746

[lgarron, 2015-09-03 02:29:11]

lgarron@chromium.org changed reviewers:
+ dgozman@chromium.org

[lgarron, 2015-09-03 02:29:11]

dgozman@, could you review?

[dgozman, 2015-09-03 20:11:05]

lgtm modulo comments

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/security/SecurityPanel.js (right):

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/security/SecurityPanel.js:466: if (listIsTruncated &&
i >= truncatedNumToShow) {
no { for one-liners

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/security/SecurityPanel.js:474: function
toggleSANTruncation() {
nit: { on next line

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/security/SecurityPanel.js:477:
truncatedSANToggle.textContent = WebInspector.UIString("Show fewer");
But all the UIs I've seen have "Show more/less".

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/security/SecurityPanel.js:479:
sanDiv.classList.add("truncated-san")
;

[lgarron, 2015-09-03 20:29:46]

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/security/SecurityPanel.js (right):

https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/security/SecurityPanel.js:477:
truncatedSANToggle.textContent = WebInspector.UIString("Show fewer");
On 2015/09/03 at 20:11:05, dgozman wrote:
> But all the UIs I've seen have "Show more/less".

"Show less" makes sense when there is a bunch of stuff, but "fewer" is more
correct for a discrete list.
It seems there is only one occurrence of "Show less" in DevTools – in fact, in
all of Chrome.

On the internal Google codebase search, there are actually more results for
"Show fewer"

[dgozman, 2015-09-03 20:54:22]

On 2015/09/03 20:29:46, lgarron wrote:
>
https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
> File Source/devtools/front_end/security/SecurityPanel.js (right):
> 
>
https://codereview.chromium.org/1323263003/diff/1/Source/devtools/front_end/s...
> Source/devtools/front_end/security/SecurityPanel.js:477:
> truncatedSANToggle.textContent = WebInspector.UIString("Show fewer");
> On 2015/09/03 at 20:11:05, dgozman wrote:
> > But all the UIs I've seen have "Show more/less".
> 
> "Show less" makes sense when there is a bunch of stuff, but "fewer" is more
> correct for a discrete list.
> It seems there is only one occurrence of "Show less" in DevTools – in fact, in
> all of Chrome.
> 
> On the internal Google codebase search, there are actually more results for
> "Show fewer"

Well, if the data says so, I won't argue with it.

[lgarron, 2015-09-03 20:55:02]

Max fired back with a web-wide Google search. :-P
So, let's go with Max's preference.

[lgarron, 2015-09-03 20:55:04]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-09-03 20:55:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1323263003/#ps40001
(title: "Show fewer. *grumble-mumble*")

[commit-bot: I haz the power, 2015-09-03 20:55:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323263003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323263003/40001

[lgarron, 2015-09-03 21:08:44]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2015-09-03 21:08:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1323263003/#ps60001
(title: "s/in total/total/")

[commit-bot: I haz the power, 2015-09-03 21:08:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323263003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323263003/60001

[commit-bot: I haz the power, 2015-09-03 22:12:41]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201746