Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323243011: Add DisplayItemList::newDisplayItems() and cleanup tests (Closed)

Created:
5 years, 3 months ago by Xianzhu
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add DisplayItemList::newDisplayItems() and cleanup tests We'll need to access DisplayItemList::newDisplayItems() to update cacheable flag of BeginSubsequence display items for https://codereview.chromium.org/1327563003/. Update layout tests and make some cleanups. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201902

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -166 lines) Patch
M Source/core/paint/DisplayItemListPaintTest.h View 7 chunks +6 lines, -18 lines 0 comments Download
M Source/core/paint/DisplayItemListPaintTest.cpp View 1 15 chunks +16 lines, -21 lines 0 comments Download
M Source/core/paint/LayoutObjectDrawingRecorderTest.cpp View 9 chunks +27 lines, -98 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.h View 2 chunks +3 lines, -9 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemListTest.cpp View 6 chunks +16 lines, -18 lines 0 comments Download
M Source/platform/graphics/paint/DrawingRecorder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Xianzhu
5 years, 3 months ago (2015-09-05 01:19:46 UTC) #2
pdr.
LGTM, much cleaner overall. https://codereview.chromium.org/1323243011/diff/1/Source/core/paint/DisplayItemListPaintTest.cpp File Source/core/paint/DisplayItemListPaintTest.cpp (right): https://codereview.chromium.org/1323243011/diff/1/Source/core/paint/DisplayItemListPaintTest.cpp#newcode130 Source/core/paint/DisplayItemListPaintTest.cpp:130: rootDisplayItemList().showDebugData(); Did you mean to ...
5 years, 3 months ago (2015-09-05 03:02:15 UTC) #4
Xianzhu
https://codereview.chromium.org/1323243011/diff/1/Source/core/paint/DisplayItemListPaintTest.cpp File Source/core/paint/DisplayItemListPaintTest.cpp (right): https://codereview.chromium.org/1323243011/diff/1/Source/core/paint/DisplayItemListPaintTest.cpp#newcode130 Source/core/paint/DisplayItemListPaintTest.cpp:130: rootDisplayItemList().showDebugData(); On 2015/09/05 03:02:15, pdr wrote: > Did you ...
5 years, 3 months ago (2015-09-08 04:58:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323243011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323243011/20001
5 years, 3 months ago (2015-09-08 04:58:40 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 08:10:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201902

Powered by Google App Engine
This is Rietveld 408576698