Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1323243005: Ensure we have some space on the stack for compilation. (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure we have some space on the stack for compilation. BUG=chromium:527345, chromium:522289 LOG=N Committed: https://crrev.com/2fe2258cc5e6db8ec5f5021ff229d3f7d17bfe61 Cr-Commit-Position: refs/heads/master@{#30595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/runtime/runtime-compiler.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Igor Sheludko
PTAL
5 years, 3 months ago (2015-09-04 16:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323243005/1
5 years, 3 months ago (2015-09-04 16:08:04 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-04 16:08:05 UTC) #6
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-04 16:18:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323243005/1
5 years, 3 months ago (2015-09-04 16:38:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 16:39:59 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 16:40:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fe2258cc5e6db8ec5f5021ff229d3f7d17bfe61
Cr-Commit-Position: refs/heads/master@{#30595}

Powered by Google App Engine
This is Rietveld 408576698