Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1323243003: Disable mobile safe browsing on public builds. (Closed)

Created:
5 years, 3 months ago by Nathan Parker
Modified:
5 years, 3 months ago
Reviewers:
nyquist, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable mobile safe browsing on public builds. It's reenabled for private builds in https://chrome-internal-review.googlesource.com/#/c/228862/ BUG=527253 Committed: https://crrev.com/452aca9e626f2205eccad423781fd2332502ab52 Cr-Commit-Position: refs/heads/master@{#347527}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
nyquist
lgtm
5 years, 3 months ago (2015-09-03 21:46:00 UTC) #2
Nathan Parker
thakis@ -- Small gyp change for your review. Thanks.
5 years, 3 months ago (2015-09-03 21:50:18 UTC) #4
Nathan Parker
-thakis, +scottmg
5 years, 3 months ago (2015-09-04 20:05:12 UTC) #6
scottmg
Is there a corresponding GN change required?
5 years, 3 months ago (2015-09-04 20:10:04 UTC) #7
Nathan Parker
On 2015/09/04 20:10:04, scottmg wrote: > Is there a corresponding GN change required? No, not ...
5 years, 3 months ago (2015-09-04 20:27:52 UTC) #8
scottmg
OK, lgtm.
5 years, 3 months ago (2015-09-04 20:41:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323243003/20001
5 years, 3 months ago (2015-09-04 21:18:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 23:32:40 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 23:33:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/452aca9e626f2205eccad423781fd2332502ab52
Cr-Commit-Position: refs/heads/master@{#347527}

Powered by Google App Engine
This is Rietveld 408576698