Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 1323243002: WIP - Rough draft of style observation in style of apply hooks. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/style/StyleObserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 #include "core/layout/LayoutTextFragment.h" 108 #include "core/layout/LayoutTextFragment.h"
109 #include "core/layout/LayoutView.h" 109 #include "core/layout/LayoutView.h"
110 #include "core/loader/DocumentLoader.h" 110 #include "core/loader/DocumentLoader.h"
111 #include "core/page/ChromeClient.h" 111 #include "core/page/ChromeClient.h"
112 #include "core/page/FocusController.h" 112 #include "core/page/FocusController.h"
113 #include "core/page/Page.h" 113 #include "core/page/Page.h"
114 #include "core/page/PointerLockController.h" 114 #include "core/page/PointerLockController.h"
115 #include "core/page/SpatialNavigation.h" 115 #include "core/page/SpatialNavigation.h"
116 #include "core/page/scrolling/ScrollState.h" 116 #include "core/page/scrolling/ScrollState.h"
117 #include "core/paint/DeprecatedPaintLayer.h" 117 #include "core/paint/DeprecatedPaintLayer.h"
118 #include "core/style/StyleObserver.h"
118 #include "core/svg/SVGDocumentExtensions.h" 119 #include "core/svg/SVGDocumentExtensions.h"
119 #include "core/svg/SVGElement.h" 120 #include "core/svg/SVGElement.h"
120 #include "platform/EventDispatchForbiddenScope.h" 121 #include "platform/EventDispatchForbiddenScope.h"
121 #include "platform/RuntimeEnabledFeatures.h" 122 #include "platform/RuntimeEnabledFeatures.h"
122 #include "platform/UserGestureIndicator.h" 123 #include "platform/UserGestureIndicator.h"
123 #include "platform/scroll/ScrollableArea.h" 124 #include "platform/scroll/ScrollableArea.h"
124 #include "wtf/BitVector.h" 125 #include "wtf/BitVector.h"
125 #include "wtf/HashFunctions.h" 126 #include "wtf/HashFunctions.h"
126 #include "wtf/text/CString.h" 127 #include "wtf/text/CString.h"
127 #include "wtf/text/StringBuilder.h" 128 #include "wtf/text/StringBuilder.h"
(...skipping 1574 matching lines...) Expand 10 before | Expand all | Expand 10 after
1702 reattachContext.resolvedStyle = newStyle.get(); 1703 reattachContext.resolvedStyle = newStyle.get();
1703 bool layoutObjectWillChange = needsAttach() || layoutObject(); 1704 bool layoutObjectWillChange = needsAttach() || layoutObject();
1704 reattach(reattachContext); 1705 reattach(reattachContext);
1705 if (layoutObjectWillChange || layoutObject()) 1706 if (layoutObjectWillChange || layoutObject())
1706 return Reattach; 1707 return Reattach;
1707 return ReattachNoLayoutObject; 1708 return ReattachNoLayoutObject;
1708 } 1709 }
1709 1710
1710 ASSERT(oldStyle); 1711 ASSERT(oldStyle);
1711 1712
1712 if (localChange != NoChange) 1713 if (localChange != NoChange) {
1714 if (document().hasStyleObserver())
1715 document().notifyStyleObservers(this, oldStyle.get(), newStyle.get() );
1713 updateCallbackSelectors(oldStyle.get(), newStyle.get()); 1716 updateCallbackSelectors(oldStyle.get(), newStyle.get());
1717 }
1714 1718
1715 if (LayoutObject* layoutObject = this->layoutObject()) { 1719 if (LayoutObject* layoutObject = this->layoutObject()) {
1716 if (localChange != NoChange || pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get()) || svgFilterNeedsLayerUpdate()) { 1720 if (localChange != NoChange || pseudoStyleCacheIsInvalid(oldStyle.get(), newStyle.get()) || svgFilterNeedsLayerUpdate()) {
1717 layoutObject->setStyle(newStyle.get()); 1721 layoutObject->setStyle(newStyle.get());
1718 } else { 1722 } else {
1719 // Although no change occurred, we use the new style so that the cou sin style sharing code won't get 1723 // Although no change occurred, we use the new style so that the cou sin style sharing code won't get
1720 // fooled into believing this style is the same. 1724 // fooled into believing this style is the same.
1721 // FIXME: We may be able to remove this hack, see discussion in 1725 // FIXME: We may be able to remove this hack, see discussion in
1722 // https://codereview.chromium.org/30453002/ 1726 // https://codereview.chromium.org/30453002/
1723 layoutObject->setStyleInternal(newStyle.get()); 1727 layoutObject->setStyleInternal(newStyle.get());
(...skipping 1777 matching lines...) Expand 10 before | Expand all | Expand 10 after
3501 { 3505 {
3502 #if ENABLE(OILPAN) 3506 #if ENABLE(OILPAN)
3503 if (hasRareData()) 3507 if (hasRareData())
3504 visitor->trace(elementRareData()); 3508 visitor->trace(elementRareData());
3505 visitor->trace(m_elementData); 3509 visitor->trace(m_elementData);
3506 #endif 3510 #endif
3507 ContainerNode::trace(visitor); 3511 ContainerNode::trace(visitor);
3508 } 3512 }
3509 3513
3510 } // namespace blink 3514 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/style/StyleObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698