Remove CONTENT_SETTINGS_NUM_TYPES (part 5)

Remove CONTENT_SETTINGS_NUM_TYPES (part 5)

Remove the remaining occurences of CONTENT_SETTINGS_NUM_TYPES by replacing
iterations over it with iterations over WebsiteSettingsRegistry.

There is actually 1 occurence left (used to sanity-check IPCs) so the value has
been renamed to CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE. This will be removed
when ContentSettingsTypes is no longer an enum.

BUG=526932
Committed: https://crrev.com/58fefc1677f4f8dfdf2d6451c42ca3684314388c
Cr-Commit-Position: refs/heads/master@{#350308}

[raymes, 2015-09-08 00:48:02]

raymes@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2015-09-10 08:13:04]

lgtm

https://codereview.chromium.org/1323143008/diff/1/components/content_settings...
File components/content_settings/core/browser/content_settings_pref_provider.cc
(right):

https://codereview.chromium.org/1323143008/diff/1/components/content_settings...
components/content_settings/core/browser/content_settings_pref_provider.cc:121:
->second->GetRuleIterator(resource_identifier, incognito);
Hmm. It's not totally obvious that the map is always going to fully populated.

Is it worth adding DCHECKs?

[raymes, 2015-09-21 07:50:44]

https://codereview.chromium.org/1323143008/diff/1/components/content_settings...
File components/content_settings/core/browser/content_settings_pref_provider.cc
(right):

https://codereview.chromium.org/1323143008/diff/1/components/content_settings...
components/content_settings/core/browser/content_settings_pref_provider.cc:121:
->second->GetRuleIterator(resource_identifier, incognito);
On 2015/09/10 08:13:04, calamity wrote:
> Hmm. It's not totally obvious that the map is always going to fully populated.
> 
> Is it worth adding DCHECKs?

Done.

[raymes, 2015-09-21 07:51:08]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 07:51:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323143008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323143008/40001

[commit-bot: I haz the power, 2015-09-21 08:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 08:03:50]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2015-09-22 01:30:57]

The CQ bit was checked by raymes@chromium.org

[raymes, 2015-09-22 01:30:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1323143008/#ps70001
(title: " ")

[commit-bot: I haz the power, 2015-09-22 01:31:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323143008/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323143008/70001

[commit-bot: I haz the power, 2015-09-22 01:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 01:42:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[raymes, 2015-09-22 02:24:41]

raymes@chromium.org changed reviewers:
+ palmer@chromium.org

[raymes, 2015-09-22 02:24:42]

+palmer for
components/content_settings/content/common/content_settings_messages.h

[palmer, 2015-09-22 21:56:23]

lgtm

[raymes, 2015-09-23 01:37:11]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-09-23 01:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323143008/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323143008/70001

[commit-bot: I haz the power, 2015-09-23 05:57:27]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2015-09-23 05:58:03]

Patchset 5 (id:??) landed as
https://crrev.com/58fefc1677f4f8dfdf2d6451c42ca3684314388c
Cr-Commit-Position: refs/heads/master@{#350308}