Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3191)

Side by Side Diff: Source/devtools/front_end/network/NetworkLogView.js

Issue 1323143005: DevTools: expose initial request priority in the Network panel UI (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review comments addressed Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.Load, this._loadEventFired, this); 109 WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.Load, this._loadEventFired, this);
110 WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._domContentLoad edEventFired, this); 110 WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._domContentLoad edEventFired, this);
111 } 111 }
112 112
113 WebInspector.NetworkLogView._isFilteredOutSymbol = Symbol("isFilteredOut"); 113 WebInspector.NetworkLogView._isFilteredOutSymbol = Symbol("isFilteredOut");
114 WebInspector.NetworkLogView._isMatchingSearchQuerySymbol = Symbol("isMatchingSea rchQuery"); 114 WebInspector.NetworkLogView._isMatchingSearchQuerySymbol = Symbol("isMatchingSea rchQuery");
115 115
116 WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws": tr ue, "wss": true}; 116 WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws": tr ue, "wss": true};
117 WebInspector.NetworkLogView._responseHeaderColumns = ["Cache-Control", "Connecti on", "Content-Encoding", "Content-Length", "ETag", "Keep-Alive", "Last-Modified" , "Server", "Vary"]; 117 WebInspector.NetworkLogView._responseHeaderColumns = ["Cache-Control", "Connecti on", "Content-Encoding", "Content-Length", "ETag", "Keep-Alive", "Last-Modified" , "Server", "Vary"];
118 WebInspector.NetworkLogView._defaultColumnsVisibility = { 118 WebInspector.NetworkLogView._defaultColumnsVisibility = {
119 method: false, status: true, protocol: false, scheme: false, domain: false, remoteAddress: false, type: true, initiator: true, cookies: false, setCookies: f alse, size: true, time: true, connectionId: false, 119 method: false, status: true, protocol: false, scheme: false, domain: false, remoteAddress: false, type: true, initiator: true, cookies: false, setCookies: f alse, size: true, time: true, priority: false, connectionId: false,
120 "Cache-Control": false, "Connection": false, "Content-Encoding": false, "Con tent-Length": false, "ETag": false, "Keep-Alive": false, "Last-Modified": false, "Server": false, "Vary": false 120 "Cache-Control": false, "Connection": false, "Content-Encoding": false, "Con tent-Length": false, "ETag": false, "Keep-Alive": false, "Last-Modified": false, "Server": false, "Vary": false
121 }; 121 };
122 WebInspector.NetworkLogView._defaultRefreshDelay = 200; 122 WebInspector.NetworkLogView._defaultRefreshDelay = 200;
123 123
124 WebInspector.NetworkLogView._waterfallMinOvertime = 1; 124 WebInspector.NetworkLogView._waterfallMinOvertime = 1;
125 WebInspector.NetworkLogView._waterfallMaxOvertime = 3; 125 WebInspector.NetworkLogView._waterfallMaxOvertime = 3;
126 126
127 /** @enum {string} */ 127 /** @enum {string} */
128 WebInspector.NetworkLogView.FilterType = { 128 WebInspector.NetworkLogView.FilterType = {
129 Domain: "domain", 129 Domain: "domain",
(...skipping 26 matching lines...) Expand all
156 "scheme": WebInspector.UIString("Scheme"), 156 "scheme": WebInspector.UIString("Scheme"),
157 "domain": WebInspector.UIString("Domain"), 157 "domain": WebInspector.UIString("Domain"),
158 "remoteAddress": WebInspector.UIString("Remote Address"), 158 "remoteAddress": WebInspector.UIString("Remote Address"),
159 "type": WebInspector.UIString("Type"), 159 "type": WebInspector.UIString("Type"),
160 "initiator": WebInspector.UIString("Initiator"), 160 "initiator": WebInspector.UIString("Initiator"),
161 "cookies": WebInspector.UIString("Cookies"), 161 "cookies": WebInspector.UIString("Cookies"),
162 "setCookies": WebInspector.UIString("Set-Cookies"), 162 "setCookies": WebInspector.UIString("Set-Cookies"),
163 "size": WebInspector.UIString("Size"), 163 "size": WebInspector.UIString("Size"),
164 "time": WebInspector.UIString("Time"), 164 "time": WebInspector.UIString("Time"),
165 "connectionId": WebInspector.UIString("Connection Id"), 165 "connectionId": WebInspector.UIString("Connection Id"),
166 "priority": WebInspector.UIString("Priority"),
166 "timeline": WebInspector.UIString("Timeline"), 167 "timeline": WebInspector.UIString("Timeline"),
167 168
168 // Response header columns 169 // Response header columns
169 "Cache-Control": WebInspector.UIString("Cache-Control"), 170 "Cache-Control": WebInspector.UIString("Cache-Control"),
170 "Connection": WebInspector.UIString("Connection"), 171 "Connection": WebInspector.UIString("Connection"),
171 "Content-Encoding": WebInspector.UIString("Content-Encoding"), 172 "Content-Encoding": WebInspector.UIString("Content-Encoding"),
172 "Content-Length": WebInspector.UIString("Content-Length"), 173 "Content-Length": WebInspector.UIString("Content-Length"),
173 "ETag": WebInspector.UIString("ETag"), 174 "ETag": WebInspector.UIString("ETag"),
174 "Keep-Alive": WebInspector.UIString("Keep-Alive"), 175 "Keep-Alive": WebInspector.UIString("Keep-Alive"),
175 "Last-Modified": WebInspector.UIString("Last-Modified"), 176 "Last-Modified": WebInspector.UIString("Last-Modified"),
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 422
422 columns.push({ 423 columns.push({
423 id: "time", 424 id: "time",
424 titleDOMFragment: this._makeHeaderFragment(WebInspector.UIString("Ti me"), WebInspector.UIString("Latency")), 425 titleDOMFragment: this._makeHeaderFragment(WebInspector.UIString("Ti me"), WebInspector.UIString("Latency")),
425 title: WebInspector.NetworkLogView._columnTitles["time"], 426 title: WebInspector.NetworkLogView._columnTitles["time"],
426 weight: 6, 427 weight: 6,
427 align: WebInspector.DataGrid.Align.Right 428 align: WebInspector.DataGrid.Align.Right
428 }); 429 });
429 430
430 columns.push({ 431 columns.push({
432 id: "priority",
433 title: WebInspector.NetworkLogView._columnTitles["priority"],
434 weight: 6
435 });
436
437 columns.push({
431 id: "connectionId", 438 id: "connectionId",
432 title: WebInspector.NetworkLogView._columnTitles["connectionId"], 439 title: WebInspector.NetworkLogView._columnTitles["connectionId"],
433 weight: 6 440 weight: 6
434 }); 441 });
435 442
436 var responseHeaderColumns = WebInspector.NetworkLogView._responseHeaderC olumns; 443 var responseHeaderColumns = WebInspector.NetworkLogView._responseHeaderC olumns;
437 for (var i = 0; i < responseHeaderColumns.length; ++i) { 444 for (var i = 0; i < responseHeaderColumns.length; ++i) {
438 var headerName = responseHeaderColumns[i]; 445 var headerName = responseHeaderColumns[i];
439 var descriptor = { 446 var descriptor = {
440 id: headerName, 447 id: headerName,
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 this._sortingFunctions.scheme = WebInspector.NetworkDataGridNode.Request PropertyComparator.bind(null, "scheme", false); 614 this._sortingFunctions.scheme = WebInspector.NetworkDataGridNode.Request PropertyComparator.bind(null, "scheme", false);
608 this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.Request PropertyComparator.bind(null, "domain", false); 615 this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.Request PropertyComparator.bind(null, "domain", false);
609 this._sortingFunctions.remoteAddress = WebInspector.NetworkDataGridNode. RemoteAddressComparator; 616 this._sortingFunctions.remoteAddress = WebInspector.NetworkDataGridNode. RemoteAddressComparator;
610 this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPr opertyComparator.bind(null, "mimeType", false); 617 this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPr opertyComparator.bind(null, "mimeType", false);
611 this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.Init iatorComparator; 618 this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.Init iatorComparator;
612 this._sortingFunctions.cookies = WebInspector.NetworkDataGridNode.Reques tCookiesCountComparator; 619 this._sortingFunctions.cookies = WebInspector.NetworkDataGridNode.Reques tCookiesCountComparator;
613 this._sortingFunctions.setCookies = WebInspector.NetworkDataGridNode.Res ponseCookiesCountComparator; 620 this._sortingFunctions.setCookies = WebInspector.NetworkDataGridNode.Res ponseCookiesCountComparator;
614 this._sortingFunctions.size = WebInspector.NetworkDataGridNode.SizeCompa rator; 621 this._sortingFunctions.size = WebInspector.NetworkDataGridNode.SizeCompa rator;
615 this._sortingFunctions.time = WebInspector.NetworkDataGridNode.RequestPr opertyComparator.bind(null, "duration", false); 622 this._sortingFunctions.time = WebInspector.NetworkDataGridNode.RequestPr opertyComparator.bind(null, "duration", false);
616 this._sortingFunctions.connectionId = WebInspector.NetworkDataGridNode.R equestPropertyComparator.bind(null, "connectionId", false); 623 this._sortingFunctions.connectionId = WebInspector.NetworkDataGridNode.R equestPropertyComparator.bind(null, "connectionId", false);
624 this._sortingFunctions.priority = WebInspector.NetworkDataGridNode.Initi alPriorityComparator;
617 this._sortingFunctions.timeline = WebInspector.NetworkDataGridNode.Reque stPropertyComparator.bind(null, "startTime", false); 625 this._sortingFunctions.timeline = WebInspector.NetworkDataGridNode.Reque stPropertyComparator.bind(null, "startTime", false);
618 this._sortingFunctions.startTime = WebInspector.NetworkDataGridNode.Requ estPropertyComparator.bind(null, "startTime", false); 626 this._sortingFunctions.startTime = WebInspector.NetworkDataGridNode.Requ estPropertyComparator.bind(null, "startTime", false);
619 this._sortingFunctions.endTime = WebInspector.NetworkDataGridNode.Reques tPropertyComparator.bind(null, "endTime", false); 627 this._sortingFunctions.endTime = WebInspector.NetworkDataGridNode.Reques tPropertyComparator.bind(null, "endTime", false);
620 this._sortingFunctions.responseTime = WebInspector.NetworkDataGridNode.R equestPropertyComparator.bind(null, "responseReceivedTime", false); 628 this._sortingFunctions.responseTime = WebInspector.NetworkDataGridNode.R equestPropertyComparator.bind(null, "responseReceivedTime", false);
621 this._sortingFunctions.duration = WebInspector.NetworkDataGridNode.Reque stPropertyComparator.bind(null, "duration", true); 629 this._sortingFunctions.duration = WebInspector.NetworkDataGridNode.Reque stPropertyComparator.bind(null, "duration", true);
622 this._sortingFunctions.latency = WebInspector.NetworkDataGridNode.Reques tPropertyComparator.bind(null, "latency", true); 630 this._sortingFunctions.latency = WebInspector.NetworkDataGridNode.Reques tPropertyComparator.bind(null, "latency", true);
623 }, 631 },
624 632
625 _createCalculators: function() 633 _createCalculators: function()
626 { 634 {
(...skipping 1475 matching lines...) Expand 10 before | Expand all | Expand 10 after
2102 return false; 2110 return false;
2103 return true; 2111 return true;
2104 } 2112 }
2105 2113
2106 WebInspector.NetworkLogView.EventTypes = { 2114 WebInspector.NetworkLogView.EventTypes = {
2107 RequestSelected: "RequestSelected", 2115 RequestSelected: "RequestSelected",
2108 SearchCountUpdated: "SearchCountUpdated", 2116 SearchCountUpdated: "SearchCountUpdated",
2109 SearchIndexUpdated: "SearchIndexUpdated", 2117 SearchIndexUpdated: "SearchIndexUpdated",
2110 UpdateRequest: "UpdateRequest" 2118 UpdateRequest: "UpdateRequest"
2111 }; 2119 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698