Issue 132313013: Revert of Change growth function for SkWriter32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132313013: Revert of Change growth function for SkWriter32 (Closed)

Created:
6 years, 10 months ago by mtklein

Modified:
6 years, 10 months ago

Reviewers:
iancottrell, tomhudson, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@no_external_test

Visibility:
Public.

Revert of Change growth function for SkWriter32 (https://codereview.chromium.org/150663014/) Reason for revert: See https://codereview.chromium.org/152703007/. Original issue's description: > Change growth function for SkWriter32 > > Add setCountExact to SkTDArray to allow external control of array growth. > Use it to allow SkWriter to control the buffer growth pattern. > Change buffer growth pattern to 1.5n+4096 > > BUG=skia:2125 > > Committed: http://code.google.com/p/skia/source/detail?r=13401 TBR=tomhudson@google.com,reed@google.com,iancottrell@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2125 Committed: http://code.google.com/p/skia/source/detail?r=13406

Created: 6 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -72 lines)			Patch
	M	include/core/SkTDArray.h	View		4 chunks	+25 lines, -66 lines	0 comments	Download
	M	src/core/SkWriter32.cpp	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/132313013/1

6 years, 10 months ago (2014-02-11 15:56:50 UTC) #2

Message was sent while issue was closed.

Change committed as 13406