New API to copy syncfs folder to localfs.

chrome/browser/extensions/api/developer_private/developer_private_api.h

Index: chrome/browser/extensions/api/developer_private/developer_private_api.h
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h
index d747fd1d312461a4e15a0b35bd0418c1b75195a6..6c732d6fec053f2f885ad3de05a5dca952dacc60 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h
@@ -366,21 +366,21 @@ class DeveloperPrivateIsProfileManagedFunction
    virtual bool RunImpl() OVERRIDE;
 };
 
-class DeveloperPrivateExportSyncfsFolderToLocalfsFunction
+class DeveloperPrivateLoadDirectoryFunction
     : public ChromeAsyncExtensionFunction {
   public:
-   DECLARE_EXTENSION_FUNCTION("developerPrivate.exportSyncfsFolderToLocalfs",
+   DECLARE_EXTENSION_FUNCTION("developerPrivate.loadDirectory",
                               DEVELOPERPRIVATE_LOADUNPACKEDCROS);
 
-   DeveloperPrivateExportSyncfsFolderToLocalfsFunction();
+   DeveloperPrivateLoadDirectoryFunction();
 
   protected:
-   virtual ~DeveloperPrivateExportSyncfsFolderToLocalfsFunction();
+   virtual ~DeveloperPrivateLoadDirectoryFunction();
 
    // ExtensionFunction
    virtual bool RunImpl() OVERRIDE;
 
-   void ClearPrexistingDirectoryContent(const base::FilePath& project_path);
+   void ClearExistingDirectoryContent(const base::FilePath& project_path);
 
    void ReadSyncFileSystemDirectory(const base::FilePath& project_path,
                                     const base::FilePath& destination_path);
@@ -402,32 +402,21 @@ class DeveloperPrivateExportSyncfsFolderToLocalfsFunction
    void CopyFile(const base::FilePath& src_path,
                  const base::FilePath& dest_path);
 
+   void Load();
+
    scoped_refptr<fileapi::FileSystemContext> context_;
 
+   std::string project_base_url_;
+   base::FilePath project_path_;

[asargent_no_longer_on_chrome, 2014/01/16 22:57:33]

nit: it's not obvious what the difference between these 2 is ; please add a
comment for each one (or a single comment describing the difference between the
two)

[Gaurav, 2014/01/17 00:21:27]

Done.

+
   private:
-   int pendingCopyOperationsCount_;
+   int pending_copy_operations_count_;
 
    // This is set to false if any of the copyFile operations fail on
    // call of the API. It is returned as a response of the API call.
    bool success_;
-};
-
-class DeveloperPrivateLoadProjectFunction
-    : public ChromeAsyncExtensionFunction {
-  public:
-   DECLARE_EXTENSION_FUNCTION("developerPrivate.loadProject",
-                              DEVELOPERPRIVATE_LOADPROJECT);
-
-   DeveloperPrivateLoadProjectFunction();
-
-  protected:
-   virtual ~DeveloperPrivateLoadProjectFunction();
-
-   // ExtensionFunction
-   virtual bool RunImpl() OVERRIDE;
 
-   void GetUnpackedExtension(const base::FilePath& path,
-                             const ExtensionSet* extensions);
+   base::FilePath path_;

[asargent_no_longer_on_chrome, 2014/01/16 22:57:33]

Also, how does |path_| here relate to |project_base_url_| and |project_path_|
above? Please add a comment, and consider renaming it to be more clear

 };
 
 }  // namespace api