media/capture/video/linux/video_capture_device_linux.h - Issue 1323093006: Change the media::PowerLineFrequency from an enum class to a proper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/linux/video_capture_device_linux.h

Issue 1323093006: Change the media::PowerLineFrequency from an enum class to a proper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass around PowerLineFrequency objects in VideoCaptureDevice instead of integers Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/capture/video/linux/video_capture_device_linux.h

diff --git a/media/capture/video/linux/video_capture_device_linux.h b/media/capture/video/linux/video_capture_device_linux.h

index 61e2cba6c273b481b3eeabcbe88fdcfeea032f3f..dbe4182710dbdac90ae3dc59e20902c82a0e8b2e 100644

--- a/media/capture/video/linux/video_capture_device_linux.h

+++ b/media/capture/video/linux/video_capture_device_linux.h

@@ -41,7 +41,8 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice {

void SetRotation(int rotation);

private:

- static int TranslatePowerLineFrequencyToV4L2(int frequency);

+ static int TranslatePowerLineFrequencyToV4L2(

+ media::PowerLineFrequency frequency);

// Internal delegate doing the actual capture setting, buffer allocation and

// circulation with the V4L2 API. Created and deleted in the thread where

« no previous file with comments | « media/base/video_capture_types_unittest.cc ('k') | media/capture/video/linux/video_capture_device_linux.cc » ('j') | no next file with comments »