Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: media/base/video_capture_types.cc

Issue 1323093006: Change the media::PowerLineFrequency from an enum class to a proper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass around PowerLineFrequency objects in VideoCaptureDevice instead of integers Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_capture_types.h ('k') | media/base/video_capture_types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_capture_types.cc
diff --git a/media/base/video_capture_types.cc b/media/base/video_capture_types.cc
index 0bc6ae639511625fe34fa214aacb01fd65d860d9..ed22e7d5bf2bf816b28bd209a5cf359c0cbb3c6a 100644
--- a/media/base/video_capture_types.cc
+++ b/media/base/video_capture_types.cc
@@ -11,6 +11,33 @@
namespace media {
+PowerLineFrequency::PowerLineFrequency() {
+ freq_ = FREQUENCY_DEFAULT;
+}
+
+PowerLineFrequency::PowerLineFrequency(int freq) {
+ freq_ = freq;
+ check();
+}
+
+PowerLineFrequency& PowerLineFrequency::operator=(int freq) {
+ freq_ = freq;
+ check();
+ return *this;
+}
+
+bool PowerLineFrequency::valid() {
+ bool ok = freq_ == FREQUENCY_DEFAULT
+ || freq_ == FREQUENCY_50HZ
+ || freq_ == FREQUENCY_60HZ;
+ return ok;
+}
+
+void PowerLineFrequency::check() {
+ DCHECK(valid());
+}
+
+
// This list is ordered by precedence of use.
static VideoPixelFormat const kSupportedCapturePixelFormats[] = {
PIXEL_FORMAT_I420,
« no previous file with comments | « media/base/video_capture_types.h ('k') | media/base/video_capture_types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698