Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2062)

Unified Diff: Source/wtf/PartitionAlloc.h

Issue 1323093004: Clean up and clarify PartitionAlloc (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/wtf/PartitionAlloc.h
diff --git a/Source/wtf/PartitionAlloc.h b/Source/wtf/PartitionAlloc.h
index e2e68733ed2ff1a35b4217e13f446a5d3c62b97a..d0c22ac9e3995a57704b00c46970a4cca9de7375 100644
--- a/Source/wtf/PartitionAlloc.h
+++ b/Source/wtf/PartitionAlloc.h
@@ -141,10 +141,10 @@ static const size_t kMaxPartitionPagesPerSlotSpan = 4;
// To avoid fragmentation via never-used freelist entries, we hand out partition
// freelist sections gradually, in units of the dominant system page size.
-// What we're actually doing is avoiding filling the full partition page
-// (typically 16KB) will freelist pointers right away. Writing freelist
-// pointers will fault and dirty a private page, which is very wasteful if we
-// never actually store objects there.
+// What we're actually doing is avoiding filling the full partition page (16 KB)
+// with freelist pointers right away. Writing freelist pointers will fault and
+// dirty a private page, which is very wasteful if we never actually store
+// objects there.
static const size_t kNumSystemPagesPerPartitionPage = kPartitionPageSize / kSystemPageSize;
static const size_t kMaxSystemPagesPerSlotSpan = kNumSystemPagesPerPartitionPage * kMaxPartitionPagesPerSlotSpan;
@@ -726,7 +726,7 @@ ALWAYS_INLINE void partitionFreeGeneric(PartitionRootGeneric* root, void* ptr)
#endif
}
-ALWAYS_INLINE size_t partitionDirectMapSize(size_t size)
+ALWAYS_INLINE size_t partitionRoundUpToSystemPage(size_t size)
{
// Caller must check that the size is not above the kGenericMaxDirectMapped
// limit before calling. This also guards against integer overflow in the
@@ -749,7 +749,7 @@ ALWAYS_INLINE size_t partitionAllocActualSize(PartitionRootGeneric* root, size_t
// Too large to allocate => return the size unchanged.
} else {
ASSERT(bucket == &PartitionRootBase::gPagedBucket);
- size = partitionDirectMapSize(size);
+ size = partitionRoundUpToSystemPage(size);
}
return partitionCookieSizeAdjustSubtract(size);
#endif

Powered by Google App Engine
This is Rietveld 408576698