Issue 1323093002: CMake tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1323093002: CMake tweaks (Closed)

Created:
5 years, 3 months ago by mtklein_C

Modified:
5 years, 3 months ago

Reviewers:
hal.canary

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

CMake tweaks - I think CMake 3.1 is enough for now. - Ubuntu works too. BUG=skia:4269 Committed: https://skia.googlesource.com/skia/+/0ce744e3069e04cc61733fdb247c2d938de5e1a2

Patch Set 1 #

Patch Set 2 : update readme #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	cmake/CMakeLists.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	cmake/README.md	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323093002/20001

5 years, 3 months ago (2015-09-01 16:17:53 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-01 16:22:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0ce744e3069e04cc61733fdb247c2d938de5e1a2

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages