Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1323073005: Remove Element.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed)

Created:
5 years, 3 months ago by tanay.c
Modified:
5 years, 3 months ago
Reviewers:
philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove Element.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight Intent to remove link @ https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yKQdi4hnE_Y BUG=504578 Committed: https://crrev.com/9e89ec52badf629078f9577b8248b1dff0c43558 git-svn-id: svn://svn.chromium.org/blink/trunk@202131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
D LayoutTests/fast/html/element-offset.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/html/element-offset-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
tanay.c
Patch to remove the offset* variables from Element.idl PTAL. (Continuation of deprecate CL @ https://codereview.chromium.org/1231533002/ ...
5 years, 3 months ago (2015-09-03 05:42:03 UTC) #2
philipj_slow
Can you send and Intent to Remove for this?
5 years, 3 months ago (2015-09-03 09:14:36 UTC) #3
philipj_slow
The change itself LG2M, and I think you'll get three quick LG2Ms on blink-dev.
5 years, 3 months ago (2015-09-03 09:15:28 UTC) #4
philipj_slow
lgtm
5 years, 3 months ago (2015-09-03 20:59:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323073005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323073005/20001
5 years, 3 months ago (2015-09-03 20:59:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/64889)
5 years, 3 months ago (2015-09-03 23:46:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323073005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323073005/20001
5 years, 3 months ago (2015-09-10 08:05:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67527) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-10 08:07:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323073005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323073005/20001
5 years, 3 months ago (2015-09-11 05:49:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/96121) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-11 05:51:09 UTC) #17
philipj_slow
Looks like you need to rebase this to resolve conflicts.
5 years, 3 months ago (2015-09-11 07:06:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323073005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323073005/60001
5 years, 3 months ago (2015-09-11 11:13:05 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202131
5 years, 3 months ago (2015-09-11 12:24:56 UTC) #24
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:21:38 UTC) #25
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9e89ec52badf629078f9577b8248b1dff0c43558

Powered by Google App Engine
This is Rietveld 408576698