Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1323073004: Revert of Replace references to old blink isolate files in gtest_test_instance.py. (Closed)

Created:
5 years, 3 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace references to old blink isolate files in gtest_test_instance.py. (patchset #1 id:1 of https://codereview.chromium.org/1311533007/ ) Reason for revert: broke android build, new isolate file probably needs an android clause https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37274 Original issue's description: > Replace references to old blink isolate files in gtest_test_instance.py. > > BUG=524758 > > Committed: https://crrev.com/1f9c42098fe19c3daf4611fc58442009abd3ada9 > Cr-Commit-Position: refs/heads/master@{#346808} TBR=dpranke@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524758 Committed: https://crrev.com/1562830c56d1cc5ca70f51c4dd54660c1d3d641d Cr-Commit-Position: refs/heads/master@{#346832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
joelo
Created Revert of Replace references to old blink isolate files in gtest_test_instance.py.
5 years, 3 months ago (2015-09-02 03:22:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323073004/1
5 years, 3 months ago (2015-09-02 03:22:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 03:22:48 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 03:23:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1562830c56d1cc5ca70f51c4dd54660c1d3d641d
Cr-Commit-Position: refs/heads/master@{#346832}

Powered by Google App Engine
This is Rietveld 408576698