Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: runtime/vm/object.h

Issue 1323063004: Fix Dartium by supporting external strings as well in Symbols::FromConcatAll (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Formatting Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/object_test.cc » ('j') | runtime/vm/symbols.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_OBJECT_H_ 5 #ifndef VM_OBJECT_H_
6 #define VM_OBJECT_H_ 6 #define VM_OBJECT_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/utils.h" 10 #include "platform/utils.h"
(...skipping 6505 matching lines...) Expand 10 before | Expand all | Expand 10 after
6516 Snapshot::Kind kind); 6516 Snapshot::Kind kind);
6517 6517
6518 static intptr_t NextFieldOffset() { 6518 static intptr_t NextFieldOffset() {
6519 // Indicates this class cannot be extended by dart code. 6519 // Indicates this class cannot be extended by dart code.
6520 return -kWordSize; 6520 return -kWordSize;
6521 } 6521 }
6522 6522
6523 friend class Class; 6523 friend class Class;
6524 friend class String; 6524 friend class String;
6525 friend class SnapshotReader; 6525 friend class SnapshotReader;
6526 friend class Symbols;
6526 }; 6527 };
6527 6528
6528 6529
6529 class ExternalTwoByteString : public AllStatic { 6530 class ExternalTwoByteString : public AllStatic {
6530 public: 6531 public:
6531 static uint16_t CharAt(const String& str, intptr_t index) { 6532 static uint16_t CharAt(const String& str, intptr_t index) {
6532 NoSafepointScope no_safepoint; 6533 NoSafepointScope no_safepoint;
6533 return *CharAddr(str, index); 6534 return *CharAddr(str, index);
6534 } 6535 }
6535 6536
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
6594 Snapshot::Kind kind); 6595 Snapshot::Kind kind);
6595 6596
6596 static intptr_t NextFieldOffset() { 6597 static intptr_t NextFieldOffset() {
6597 // Indicates this class cannot be extended by dart code. 6598 // Indicates this class cannot be extended by dart code.
6598 return -kWordSize; 6599 return -kWordSize;
6599 } 6600 }
6600 6601
6601 friend class Class; 6602 friend class Class;
6602 friend class String; 6603 friend class String;
6603 friend class SnapshotReader; 6604 friend class SnapshotReader;
6605 friend class Symbols;
6604 }; 6606 };
6605 6607
6606 6608
6607 // Class Bool implements Dart core class bool. 6609 // Class Bool implements Dart core class bool.
6608 class Bool : public Instance { 6610 class Bool : public Instance {
6609 public: 6611 public:
6610 bool value() const { 6612 bool value() const {
6611 return raw_ptr()->value_; 6613 return raw_ptr()->value_;
6612 } 6614 }
6613 6615
(...skipping 1447 matching lines...) Expand 10 before | Expand all | Expand 10 after
8061 8063
8062 8064
8063 RawObject* MegamorphicCache::GetTargetFunction(const Array& array, 8065 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
8064 intptr_t index) { 8066 intptr_t index) {
8065 return array.At((index * kEntryLength) + kTargetFunctionIndex); 8067 return array.At((index * kEntryLength) + kTargetFunctionIndex);
8066 } 8068 }
8067 8069
8068 } // namespace dart 8070 } // namespace dart
8069 8071
8070 #endif // VM_OBJECT_H_ 8072 #endif // VM_OBJECT_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/object_test.cc » ('j') | runtime/vm/symbols.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698