Fix cropped floating gesture candidate window

ui/keyboard/keyboard_controller.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/keyboard/keyboard_controller.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 253 matching lines @@
     FOR_EACH_OBSERVER(KeyboardControllerObserver,
                       observer_list_,
                       OnKeyboardBoundsChanging(new_bounds));
     if (keyboard::IsKeyboardOverscrollEnabled()) {
       // Adjust the height of the viewport for visible windows on the primary
       // display.
       // TODO(kevers): Add EnvObserver to properly initialize insets if a
       // window is created while the keyboard is visible.
       scoped_ptr<content::RenderWidgetHostIterator> widgets(
           content::RenderWidgetHost::GetRenderWidgetHosts());
-      aura::Window* keyboard_window = proxy_->GetKeyboardWindow();
-      aura::Window* root_window = keyboard_window->GetRootWindow();
+      aura::Window* root_window = proxy_->GetKeyboardWindow()->GetRootWindow();
       while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
         content::RenderWidgetHostView* view = widget->GetView();
         // Can be NULL, e.g. if the RenderWidget is being destroyed or
         // the render process crashed.
         if (view) {
           aura::Window* window = view->GetNativeView();
-          // If virtual keyboard failed to load, a widget that displays error
-          // message will be created and adds as a child of the virtual keyboard
-          // window. We want to avoid add BoundsChangedObserver to that window.
-          if (!keyboard_window->Contains(window) &&
+          if (proxy_->ShouldWindowOverscroll(window) &&
               window->GetRootWindow() == root_window) {

[oshima, 2015/09/23 19:57:27]

looks like this check is a dup?

[bshe, 2015/09/24 11:56:15]

I think this check preventing overscoll on windows that are not appear in the
same root window as the virtual keyboard window. So it is probably not a dup? I
can move the logic into "ShouldWindowOverscroll" though. WDYT?

[oshima, 2015/09/24 17:28:07]

Yeah,that sounds better because it's checking against the keyboard window
obtained from the pxory.

[bshe, 2015/09/28 14:42:40]

Done.

             gfx::Rect window_bounds = window->GetBoundsInScreen();
             gfx::Rect intersect = gfx::IntersectRects(window_bounds,
                                                       new_bounds);
             int overlap = intersect.height();
             if (overlap > 0 && overlap < window_bounds.height())
               view->SetInsets(gfx::Insets(0, 0, overlap, 0));
             else
               view->SetInsets(gfx::Insets());
             AddBoundsChangedObserver(window);
           }
@@ skipping 172 matching lines @@
 
 bool KeyboardController::ShouldEnableInsets(aura::Window* window) {
   aura::Window* keyboard_window = proxy_->GetKeyboardWindow();
   return (keyboard_window->GetRootWindow() == window->GetRootWindow() &&
           keyboard::IsKeyboardOverscrollEnabled() &&
           keyboard_window->IsVisible() && keyboard_visible_);
 }
 
 void KeyboardController::UpdateWindowInsets(aura::Window* window) {
   aura::Window* keyboard_window = proxy_->GetKeyboardWindow();
-  if (window == keyboard_window)
+  if (!proxy_->ShouldWindowOverscroll(window))
     return;
 
   scoped_ptr<content::RenderWidgetHostIterator> widgets(
       content::RenderWidgetHost::GetRenderWidgetHosts());
   while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
     content::RenderWidgetHostView* view = widget->GetView();
     if (view && window->Contains(view->GetNativeView())) {
       gfx::Rect window_bounds = view->GetNativeView()->GetBoundsInScreen();
       gfx::Rect intersect =
           gfx::IntersectRects(window_bounds, keyboard_window->bounds());
@@ skipping 112 matching lines @@
   proxy_->HideKeyboardContainer(container_.get());
 }
 
 void KeyboardController::AddBoundsChangedObserver(aura::Window* window) {
   aura::Window* target_window = window ? window->GetToplevelWindow() : nullptr;
   if (target_window)
     window_bounds_observer_->AddObservedWindow(target_window);
 }
 
 }  // namespace keyboard