Fix cropped floating gesture candidate window

chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/ash_keyboard_controller_proxy.h"
 
+#include "ash/root_window_controller.h"
 #include "ash/shell.h"
+#include "ash/shell_window_ids.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "content/public/browser/host_zoom_map.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/view_type_utils.h"
@@ skipping 156 matching lines @@
 void AshKeyboardControllerProxy::ShowKeyboardContainer(
     aura::Window* container) {
   // TODO(bshe): Implement logic to decide which root window should display
   // virtual keyboard. http://crbug.com/303429
   if (container->GetRootWindow() != ash::Shell::GetPrimaryRootWindow())
     NOTIMPLEMENTED();
 
   KeyboardControllerProxy::ShowKeyboardContainer(container);
 }
 
+bool AshKeyboardControllerProxy::ShouldWindowOverscroll(
+    aura::Window* window) const {
+  ash::RootWindowController* root_window_controller =
+      ash::GetRootWindowController(window->GetRootWindow());
+  if (!root_window_controller)

[oshima, 2015/09/23 19:57:27]

can this happen? If not, please use DCHECK instead.

[bshe, 2015/09/24 11:56:15]

I think so. One window (I am not sure which) doesnt seem to have a root window
and crashed Chrome without the check.

[oshima, 2015/09/24 17:28:07]

can you check the root window instead then?

[bshe, 2015/09/28 14:42:40]

Done.

+    return true;
+
+  // Shell ime window container contains virtual keyboard windows and IME
+  // windows(IME windows are created by chrome.app.window.create api). They
+  // should never be overscrolled.
+  return !root_window_controller
+              ->GetContainer(ash::kShellWindowId_ImeWindowParentContainer)
+              ->Contains(window);
+}
+
 void AshKeyboardControllerProxy::SetUpdateInputType(ui::TextInputType type) {
   // TODO(bshe): Need to check the affected window's profile once multi-profile
   // is supported.
   extensions::EventRouter* router =
       extensions::EventRouter::Get(browser_context());
 
   if (!router->HasEventListener(
           virtual_keyboard_private::OnTextInputBoxFocused::kEventName)) {
     return;
   }
 
   scoped_ptr<base::ListValue> event_args(new base::ListValue());
   scoped_ptr<base::DictionaryValue> input_context(new base::DictionaryValue());
   input_context->SetString("type",
                            virtual_keyboard_private::ToString(
                                TextInputTypeToGeneratedInputTypeEnum(type)));
   event_args->Append(input_context.release());
 
   scoped_ptr<extensions::Event> event(new extensions::Event(
       extensions::events::VIRTUAL_KEYBOARD_PRIVATE_ON_TEXT_INPUT_BOX_FOCUSED,
       virtual_keyboard_private::OnTextInputBoxFocused::kEventName,
       event_args.Pass()));
   event->restrict_to_browser_context = browser_context();
   router->DispatchEventToExtension(kVirtualKeyboardExtensionID, event.Pass());
 }