Fix cropped floating gesture candidate window

ui/keyboard/content/keyboard_ui_content.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/keyboard/content/keyboard_ui_content.h"
 
 #include "base/command_line.h"
 #include "base/values.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_iterator.h"
@@ skipping 142 matching lines @@
   DCHECK(keyboard_contents_);
   if (keyboard_contents_->GetURL() != default_url_) {
     // TODO(bshe): The height of system virtual keyboard and IME virtual
     // keyboard may different. The height needs to be restored too.
     LoadContents(default_url_);
   }
 }
 
 void KeyboardUIContent::UpdateInsetsForWindow(aura::Window* window) {
   aura::Window* keyboard_window = GetKeyboardWindow();
+  if (!ShouldWindowOverscroll(window))
+    return;
+
   scoped_ptr<content::RenderWidgetHostIterator> widgets(
       content::RenderWidgetHost::GetRenderWidgetHosts());
   while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
     content::RenderWidgetHostView* view = widget->GetView();
     if (view && window->Contains(view->GetNativeView())) {
       gfx::Rect window_bounds = view->GetNativeView()->GetBoundsInScreen();
       gfx::Rect intersect =
           gfx::IntersectRects(window_bounds, keyboard_window->bounds());
       int overlap = ShouldEnableInsets(window) ? intersect.height() : 0;
       if (overlap > 0 && overlap < window_bounds.height())
@@ skipping 18 matching lines @@
     keyboard_contents_->GetNativeView()->AddObserver(this);
   }
 
   return keyboard_contents_->GetNativeView();
 }
 
 bool KeyboardUIContent::HasKeyboardWindow() const {
   return keyboard_contents_;
 }
 
+bool KeyboardUIContent::ShouldWindowOverscroll(aura::Window* window) const {
+  return true;
+}
+
 void KeyboardUIContent::ReloadKeyboardIfNeeded() {
   DCHECK(keyboard_contents_);
   if (keyboard_contents_->GetURL() != GetVirtualKeyboardUrl()) {
     if (keyboard_contents_->GetURL().GetOrigin() !=
         GetVirtualKeyboardUrl().GetOrigin()) {
       // Sets keyboard window rectangle to 0 and close current page before
       // navigate to a keyboard in a different extension. This keeps the UX the
       // same as Android. Note we need to explicitly close current page as it
       // might try to resize keyboard window in javascript on a resize event.
       GetKeyboardWindow()->SetBounds(gfx::Rect());
       keyboard_contents_->ClosePage();
       keyboard_controller()->SetKeyboardMode(FULL_WIDTH);
     }
     LoadContents(GetVirtualKeyboardUrl());
   }
 }
 
 void KeyboardUIContent::InitInsets(const gfx::Rect& new_bounds) {
   // Adjust the height of the viewport for visible windows on the primary
   // display.
   // TODO(kevers): Add EnvObserver to properly initialize insets if a
   // window is created while the keyboard is visible.
   scoped_ptr<content::RenderWidgetHostIterator> widgets(
       content::RenderWidgetHost::GetRenderWidgetHosts());
-  aura::Window* keyboard_window = GetKeyboardWindow();
-  aura::Window* root_window = keyboard_window->GetRootWindow();
   while (content::RenderWidgetHost* widget = widgets->GetNextHost()) {
     content::RenderWidgetHostView* view = widget->GetView();
     // Can be NULL, e.g. if the RenderWidget is being destroyed or
     // the render process crashed.
     if (view) {
       aura::Window* window = view->GetNativeView();
-      // If virtual keyboard failed to load, a widget that displays error
-      // message will be created and adds as a child of the virtual keyboard
-      // window. We want to avoid add BoundsChangedObserver to that window.
-      if (!keyboard_window->Contains(window) &&
-          window->GetRootWindow() == root_window) {
+      if (ShouldWindowOverscroll(window)) {
         gfx::Rect window_bounds = window->GetBoundsInScreen();
         gfx::Rect intersect = gfx::IntersectRects(window_bounds,
                                                   new_bounds);
         int overlap = intersect.height();
         if (overlap > 0 && overlap < window_bounds.height())
           view->SetInsets(gfx::Insets(0, 0, overlap, 0));
         else
           view->SetInsets(gfx::Insets());
         AddBoundsChangedObserver(window);
       }
@@ skipping 28 matching lines @@
         shadow_->layer());
   }
 
   shadow_->SetContentBounds(new_bounds);
 }
 
 void KeyboardUIContent::OnWindowDestroyed(aura::Window* window) {
   window->RemoveObserver(this);
 }
 
+const aura::Window* KeyboardUIContent::GetKeyboardRootWindow() const {
+  if (!keyboard_contents_) {
+    return nullptr;
+  }
+  return keyboard_contents_->GetNativeView()->GetRootWindow();
+}
+
 void KeyboardUIContent::LoadContents(const GURL& url) {
   if (keyboard_contents_) {
     content::OpenURLParams params(
         url,
         content::Referrer(),
         SINGLETON_TAB,
         ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
         false);
     keyboard_contents_->OpenURL(params);
   }
@@ skipping 16 matching lines @@
           keyboard_controller()->keyboard_visible());
 }
 
 void KeyboardUIContent::AddBoundsChangedObserver(aura::Window* window) {
   aura::Window* target_window = window ? window->GetToplevelWindow() : nullptr;
   if (target_window)
     window_bounds_observer_->AddObservedWindow(target_window);
 }
 
 }  // namespace keyboard