Source/core/layout/LayoutGrid.h - Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutGrid.h

Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggested changes. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutGrid.h

diff --git a/Source/core/layout/LayoutGrid.h b/Source/core/layout/LayoutGrid.h

index 275673d0f5ecb085af173ef03745e13f3a72853a..9df305aae7e28f8f479d023b72f417993423dda1 100644

--- a/Source/core/layout/LayoutGrid.h

+++ b/Source/core/layout/LayoutGrid.h

@@ -135,7 +135,8 @@ private:

template <TrackSizeComputationPhase> void resolveContentBasedTrackSizingFunctionsForItems(GridTrackSizingDirection, GridSizingData&, const GridItemsSpanGroupRange&);

template <TrackSizeComputationPhase> void distributeSpaceToTracks(Vector<GridTrack*>&, const Vector<GridTrack*>* growBeyondGrowthLimitsTracks, GridSizingData&, LayoutUnit& availableLogicalSpace);

- double computeNormalizedFractionBreadth(Vector<GridTrack>&, const GridSpan& tracksSpan, GridTrackSizingDirection, LayoutUnit availableLogicalSpace) const;

+ typedef HashSet<size_t, DefaultHash<unsigned>::Hash, WTF::UnsignedWithZeroKeyHashTraits<size_t>> TrackIndexSet;

+ double findFrUnitSize(Vector<GridTrack>&, const GridSpan&, GridTrackSizingDirection, LayoutUnit spaceToFill, TrackIndexSet tracksToTreatAsInflexible = TrackIndexSet()) const;

esprehn 2015/09/10 01:03:14 This is creating copies of the TrackIndexSet, you

GridTrackSize gridTrackSize(GridTrackSizingDirection, size_t) const;

« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/layout/LayoutGrid.cpp » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')