LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js - Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Function normalizedFlexFraction moved Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/flex-content-resolution-rows.html ('K') | « LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

index a74990e327f39ec6c2afe83b12eb3e6726fe22a5..db4dbb9c20888944875628890a7e3d1118c58ba9 100644

--- a/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js

@@ -56,6 +56,9 @@ testNonGridDefinitionsSetJSValues("3.1459fr", "2.718fr");

// A leading '+' is allowed.

testNonGridDefinitionsSetJSValues("+3fr", "+4fr", "3fr", "4fr", "3fr", "4fr");

testNonGridDefinitionsSetJSValues("minmax(auto, 8vh)", "minmax(10vw, auto)", "minmax(auto, 48px)", "minmax(80px, auto)");

+// Flex factor values can be zero.

+testGridDefinitionsSetJSValues("0fr", ".0fr", "0px", "0px", "0fr", "0fr");

+testGridDefinitionsSetJSValues("minmax(0fr, 0fr)", "minmax(.0fr, .0fr)", "0px", "0px", "minmax(0fr, 0fr)", "minmax(0fr, 0fr)");

debug("");

debug("Test setting grid-template-columns and grid-template-rows to bad values through JS");

@@ -67,9 +70,9 @@ testGridDefinitionsSetBadJSValues("minmax(minmax(10px, 20px), 20px)", "minmax(10

testGridDefinitionsSetBadJSValues("minmax()", "minmax(30px 30% 30em)");

testGridDefinitionsSetBadJSValues("-2fr", "3ffr");

testGridDefinitionsSetBadJSValues("-2.05fr", "+-3fr");

-testGridDefinitionsSetBadJSValues("0fr", "1r");

+testGridDefinitionsSetBadJSValues("1f", "1r");

// A dimension doesn't allow spaces between the number and the unit.

-testGridDefinitionsSetBadJSValues(".0000fr", "13 fr");

+testGridDefinitionsSetBadJSValues(".0001 fr", "13 fr");

testGridDefinitionsSetBadJSValues("7.-fr", "-8,0fr");

// Negative values are not allowed.

testGridDefinitionsSetBadJSValues("-1px", "-6em");