Source/core/css/parser/LegacyCSSPropertyParser.cpp - Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pointers for the hashset and recursion only for computing the unit size. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js ('k') | Source/core/layout/LayoutGrid.h » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/LegacyCSSPropertyParser.cpp

diff --git a/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/Source/core/css/parser/LegacyCSSPropertyParser.cpp

index 4ff194363e6d3b2e1bb460f54bee6e15d56ea09d..a325c6de66270e4549faa86f99b5b80f96ee091e 100644

--- a/Source/core/css/parser/LegacyCSSPropertyParser.cpp

+++ b/Source/core/css/parser/LegacyCSSPropertyParser.cpp

@@ -3616,7 +3616,7 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSPropertyParser::parseGridBreadth(CS

double flexValue = currentValue->fValue;

// Fractional unit is a non-negative dimension.

- if (flexValue <= 0)

+ if (flexValue < 0)

return nullptr;

return cssValuePool().createValue(flexValue, CSSPrimitiveValue::UnitType::Fraction);