Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Applied suggested changes. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html » ('j') | Source/core/layout/LayoutGrid.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <link href="resources/grid.css" rel="stylesheet"> 3 <link href="resources/grid.css" rel="stylesheet">
4 <style> 4 <style>
5 .gridMaxMaxContent { 5 .gridMaxMaxContent {
6 grid-template-columns: 50px; 6 grid-template-columns: 50px;
7 grid-template-rows: minmax(10px, max-content) minmax(10px, 1fr); 7 grid-template-rows: minmax(10px, max-content) minmax(10px, 1fr);
8 } 8 }
9 9
10 .gridMinMinContent { 10 .gridMinMinContent {
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 </div> 120 </div>
121 </div> 121 </div>
122 122
123 <div style="width: 10px; height: 60px;"> 123 <div style="width: 10px; height: 60px;">
124 <div class="grid gridWithIntrinsicSizeBiggerThanFlex" style="height: 100%"> 124 <div class="grid gridWithIntrinsicSizeBiggerThanFlex" style="height: 100%">
125 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div> 125 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>
126 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="20"></div> 126 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="20"></div>
127 </div> 127 </div>
128 </div> 128 </div>
129 129
130 <!-- We normalize fraction flex factors to 1, so we don't keep exact proportions with >1 factors. -->
130 <div style="width: 10px; height: 60px;"> 131 <div style="width: 10px; height: 60px;">
131 <div class="grid gridWithIntrinsicSizeBiggerThanFlex"> 132 <div class="grid gridWithIntrinsicSizeBiggerThanFlex">
132 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div> 133 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>
133 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="160"></div> 134 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="80"></div>
134 </div> 135 </div>
135 </div> 136 </div>
136 137
137 <div style="width: 10px; height: 60px;"> 138 <div style="width: 10px; height: 60px;">
138 <div class="grid gridShrinkBelowItemsIntrinsicSize" style="height: 100%"> 139 <div class="grid gridShrinkBelowItemsIntrinsicSize" style="height: 100%">
139 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="20">XXXXX XXXXX XXXXX XXXXX XXXXX</div> 140 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="20">XXXXX XXXXX XXXXX XXXXX XXXXX</div>
140 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div> 141 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div>
141 </div> 142 </div>
142 </div> 143 </div>
143 144
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 <div class="grid gridWithNonFlexingItems"> 200 <div class="grid gridWithNonFlexingItems">
200 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40"></div> 201 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40"></div>
201 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div> 202 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>
202 <div class="sizedToGridArea thirdRowFirstColumn" data-expected-width="50 " data-expected-height="60">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div> 203 <div class="sizedToGridArea thirdRowFirstColumn" data-expected-width="50 " data-expected-height="60">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div>
203 <div class="sizedToGridArea fourthRowFirstColumn" data-expected-width="5 0" data-expected-height="80"></div> 204 <div class="sizedToGridArea fourthRowFirstColumn" data-expected-width="5 0" data-expected-height="80"></div>
204 </div> 205 </div>
205 </div> 206 </div>
206 207
207 </body> 208 </body>
208 </html> 209 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html » ('j') | Source/core/layout/LayoutGrid.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698