Issue 1323023005: Do not create FormDataList instances.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1323023005: Do not create FormDataList instances. (Closed)

Created:
5 years, 3 months ago by tkent

Modified:
5 years, 3 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Do not create FormDataList instances. WebSearchableFormData.cpp created FormDataList instances. However DOMFormData, which is a subclass of FormDataList, is also acceptable, and we can remove FormDataList factory. This CL has no behavior changes. BUG=528840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201894

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	Source/core/html/FormDataList.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
	M	Source/web/WebSearchableFormData.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1323023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1323023005/1

5 years, 3 months ago (2015-09-08 05:32:47 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 05:38:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201894

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages