Port uses of SkLazyPtr to SkOncePtr.

Port uses of SkLazyPtr to SkOncePtr.

This gives SkOncePtr a non-trivial destructor that uses std::default_delete
by default.  This is overrideable, as seen in SkColorTable.

SK_DECLARE_STATIC_ONCE_PTR still just leaves its pointers hanging at EOP.

BUG=skia:

No public API changes.
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/a1254acdb344174e761f5061c820559dab64a74c

Committed: https://skia.googlesource.com/skia/+/6c59d80858f453a426df9b07fdf3a8cc01e0b906

[mtklein_C, 2015-09-08 16:05:23]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-08 16:05:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322933005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322933005/60001

[mtklein_C, 2015-09-08 16:11:11]

mtklein@chromium.org changed reviewers:
+ herb@google.com

[commit-bot: I haz the power, 2015-09-08 16:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 16:20:22]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-09-08 17:07:52]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-08 17:07:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322933005/70011
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322933005/70011

[commit-bot: I haz the power, 2015-09-08 17:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 17:13:09]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-09-08 17:28:08]

I was Feeling Lucky so I did everything SkLazyPtr related.

[herb_g, 2015-09-08 20:24:34]

https://codereview.chromium.org/1322933005/diff/70011/include/core/SkColorTab...
File include/core/SkColorTable.h (right):

https://codereview.chromium.org/1322933005/diff/70011/include/core/SkColorTab...
include/core/SkColorTable.h:64: struct Free16BitCache { void
operator()(uint16_t* cache) const; };
Consider inline implementation?

https://codereview.chromium.org/1322933005/diff/70011/include/core/SkColorTab...
include/core/SkColorTable.h:67: SkOncePtr<uint16_t, Free16BitCache> f16BitCache;
It will be nice to have uint16_t[] in the future.

https://codereview.chromium.org/1322933005/diff/70011/include/private/SkOnceP...
File include/private/SkOncePtr.h (left):

https://codereview.chromium.org/1322933005/diff/70011/include/private/SkOnceP...
include/private/SkOncePtr.h:39: SkStaticOnce<T> fOnce;
Ok. So as things evolve, I don't think that name SkStaticOnce makes sense
because it does not mean static storage scope. Maybe SkBaseOncePtr?

[mtklein_C, 2015-09-08 20:33:53]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-08 20:34:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322933005/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322933005/110001

[mtklein_C, 2015-09-08 20:37:17]

https://codereview.chromium.org/1322933005/diff/70011/include/core/SkColorTab...
File include/core/SkColorTable.h (right):

https://codereview.chromium.org/1322933005/diff/70011/include/core/SkColorTab...
include/core/SkColorTable.h:64: struct Free16BitCache { void
operator()(uint16_t* cache) const; };
On 2015/09/08 20:24:34, herb_g wrote:
> Consider inline implementation?

Done.  If nothing else this is clearer to read.

https://codereview.chromium.org/1322933005/diff/70011/include/core/SkColorTab...
include/core/SkColorTable.h:67: SkOncePtr<uint16_t, Free16BitCache> f16BitCache;
On 2015/09/08 20:24:34, herb_g wrote:
> It will be nice to have uint16_t[] in the future.

This will be my next CL.

https://codereview.chromium.org/1322933005/diff/70011/include/private/SkOnceP...
File include/private/SkOncePtr.h (left):

https://codereview.chromium.org/1322933005/diff/70011/include/private/SkOnceP...
include/private/SkOncePtr.h:39: SkStaticOnce<T> fOnce;
On 2015/09/08 20:24:34, herb_g wrote:
> Ok. So as things evolve, I don't think that name SkStaticOnce makes sense
> because it does not mean static storage scope. Maybe SkBaseOncePtr?

Done, agreed.

[commit-bot: I haz the power, 2015-09-08 20:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 20:38:57]

Dry run: This issue passed the CQ dry run.

[herb_g, 2015-09-09 13:45:05]

lgtm

[mtklein, 2015-09-09 13:46:19]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-09-09 13:46:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322933005/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322933005/110001

[mtklein, 2015-09-09 13:47:38]

The CQ bit was unchecked by mtklein@google.com

[commit-bot: I haz the power, 2015-09-09 13:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[mtklein, 2015-09-09 13:47:41]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-09-09 13:47:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322933005/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322933005/110001

[commit-bot: I haz the power, 2015-09-09 13:48:37]

Committed patchset #7 (id:110001) as
https://skia.googlesource.com/skia/+/a1254acdb344174e761f5061c820559dab64a74c

[mtklein, 2015-09-09 14:10:30]

A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/1334523002/ by mtklein@google.com.

The reason for reverting is: Breaks Chrome roll.

obj/skia/ext/skia_chrome.skia_memory_dump_provider.o
does not have -I include/private on its include path, but transitively includes
SkMessageBus.h..

[mtklein, 2015-09-09 14:13:10]

On 2015/09/09 14:10:30, mtklein wrote:
> A revert of this CL (patchset #7 id:110001) has been created in
> https://codereview.chromium.org/1334523002/ by mailto:mtklein@google.com.
> 
> The reason for reverting is: Breaks Chrome roll.
> 
> obj/skia/ext/skia_chrome.skia_memory_dump_provider.o
> does not have -I include/private on its include path, but transitively
includes
> SkMessageBus.h..

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/skia/ext/skia_chrome.skia_memory_dump_provider.o.d -DV8_DEPRECATION_WARNINGS
-DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0
-DCHROMIUM_BUILD -DCR_CLANG_REVISION=245965-1 -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1
-DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA
-DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DSK_SUPPORT_GPU=1
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
'-DSK_DEFAULT_FONT_CACHE_LIMIT=(20*1024*1024)' -DSK_BUILD_FOR_MAC
-DSK_GAMMA_SRGB -DSK_GAMMA_CONTRAST=0.0 -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../.. -I../../skia/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils
-I../../third_party/skia/include/utils/mac -isysroot
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
-O2 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof
-mmacosx-version-min=10.6 -arch x86_64 -Wendif-labels -Wno-unused-parameter
-Wno-missing-field-initializers -Wno-selector-type-mismatch
-Wpartial-availability -Wheader-hygiene -Wno-char-subscripts
-Wno-unneeded-internal-declaration -Wno-covered-switch-default
-Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-unused-function -Wno-unused-variable -std=c++11
-fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics
-Xclang -load -Xclang
/b/build/slave/workdir/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics
-fno-strict-aliasing  -c ../../skia/ext/skia_memory_dump_provider.cc -o
obj/skia/ext/skia_chrome.skia_memory_dump_provider.o
In file included from ../../skia/ext/skia_memory_dump_provider.cc:12:
In file included from ../../third_party/skia/src/core/SkResourceCache.h:12:
../../third_party/skia/src/core/SkMessageBus.h:12:10: fatal error: 'SkOncePtr.h'
file not found
#include "SkOncePtr.h"

Looks like skia_memory_dump_provider is built as if it's an external client but
uses internal headers (SkResourceCache.h).

[mtklein, 2015-09-09 16:08:58]

On 2015/09/09 14:13:10, mtklein wrote:
> On 2015/09/09 14:10:30, mtklein wrote:
> > A revert of this CL (patchset #7 id:110001) has been created in
> > https://codereview.chromium.org/1334523002/ by mailto:mtklein@google.com.
> > 
> > The reason for reverting is: Breaks Chrome roll.
> > 
> > obj/skia/ext/skia_chrome.skia_memory_dump_provider.o
> > does not have -I include/private on its include path, but transitively
> includes
> > SkMessageBus.h..
> 
> FAILED: /b/build/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/skia/ext/skia_chrome.skia_memory_dump_provider.o.d
-DV8_DEPRECATION_WARNINGS
> -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0
> -DCHROMIUM_BUILD -DCR_CLANG_REVISION=245965-1 -DUSE_LIBJPEG_TURBO=1
> -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1
> -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
> -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA
> -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
> -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
> -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
> -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1
> -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
> -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
> -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1
> -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DSK_SUPPORT_GPU=1
> -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
> '-DSK_DEFAULT_FONT_CACHE_LIMIT=(20*1024*1024)' -DSK_BUILD_FOR_MAC
> -DSK_GAMMA_SRGB -DSK_GAMMA_CONTRAST=0.0 -DUSE_LIBPCI=1 -DUSE_OPENSSL=1
-DNDEBUG
> -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../.. -I../../skia/config
> -I../../third_party/skia/include/core -I../../third_party/skia/include/effects
> -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
> -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
> -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
> -I../../third_party/skia/include/utils
> -I../../third_party/skia/include/utils/mac -isysroot
>
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
> -O2 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof
> -mmacosx-version-min=10.6 -arch x86_64 -Wendif-labels -Wno-unused-parameter
> -Wno-missing-field-initializers -Wno-selector-type-mismatch
> -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts
> -Wno-unneeded-internal-declaration -Wno-covered-switch-default
> -Wno-c++11-narrowing -Wno-deprecated-register
-Wno-inconsistent-missing-override
> -Wno-shift-negative-value -Wno-unused-function -Wno-unused-variable -std=c++11
> -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics
> -Xclang -load -Xclang
>
/b/build/slave/workdir/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics
> -fno-strict-aliasing  -c ../../skia/ext/skia_memory_dump_provider.cc -o
> obj/skia/ext/skia_chrome.skia_memory_dump_provider.o
> In file included from ../../skia/ext/skia_memory_dump_provider.cc:12:
> In file included from ../../third_party/skia/src/core/SkResourceCache.h:12:
> ../../third_party/skia/src/core/SkMessageBus.h:12:10: fatal error:
'SkOncePtr.h'
> file not found
> #include "SkOncePtr.h"
> 
> Looks like skia_memory_dump_provider is built as if it's an external client
but
> uses internal headers (SkResourceCache.h).

Retrying with this fixed.

[mtklein, 2015-09-09 16:09:03]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-09-09 16:09:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322933005/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322933005/110001

[commit-bot: I haz the power, 2015-09-09 16:09:56]

Committed patchset #7 (id:110001) as
https://skia.googlesource.com/skia/+/6c59d80858f453a426df9b07fdf3a8cc01e0b906