Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 132293005: Add a DEF_GPUTEST() macro. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a DEF_GPUTEST() macro. This macro is similar to DEF_TEST() and simplifies the process of setting up a GPU test. BUG=skia:1952 TEST=tests R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=13033

Patch Set 1 #

Total comments: 2

Patch Set 2 : fatory -> factory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -133 lines) Patch
M tests/BlurTest.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M tests/ClipCacheTest.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/GLInterfaceValidation.cpp View 3 chunks +3 lines, -10 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M tests/GpuBitmapCopyTest.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 4 chunks +3 lines, -7 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 chunk +9 lines, -14 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/GrSurfaceTest.cpp View 3 chunks +4 lines, -10 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M tests/SurfaceTest.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/TestClassDef.h View 1 2 chunks +17 lines, -15 lines 0 comments Download
M tests/WritePixelsTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hi Mike, could you review this to me? Thanks,
6 years, 11 months ago (2014-01-10 01:06:23 UTC) #1
mtklein
lgtm Please just fix the typo before submitting (everyone was using the name "factory" anyway, ...
6 years, 11 months ago (2014-01-10 01:44:08 UTC) #2
tfarina
https://codereview.chromium.org/132293005/diff/1/tests/TestClassDef.h File tests/TestClassDef.h (right): https://codereview.chromium.org/132293005/diff/1/tests/TestClassDef.h#newcode34 tests/TestClassDef.h:34: #define DEF_GPUTEST(name, reporter, fatory) \ On 2014/01/10 01:44:09, mtklein ...
6 years, 11 months ago (2014-01-10 01:55:26 UTC) #3
tfarina
6 years, 11 months ago (2014-01-10 22:08:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r13033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698