Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: Source/core/animation/ElementAnimations.cpp

Issue 1322883003: Oilpan: KeyframeEffect::m_target shouldn't become stale (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/ElementAnimations.h ('k') | Source/core/animation/KeyframeEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/ElementAnimations.cpp
diff --git a/Source/core/animation/ElementAnimations.cpp b/Source/core/animation/ElementAnimations.cpp
index 9124dc603f8cc824a0472eb3fccb25c9c9330e58..1eb885958f8b1a1ca828c6cf4d7a7b19cccea473 100644
--- a/Source/core/animation/ElementAnimations.cpp
+++ b/Source/core/animation/ElementAnimations.cpp
@@ -42,6 +42,11 @@ ElementAnimations::ElementAnimations()
ElementAnimations::~ElementAnimations()
{
+#if !ENABLE(OILPAN)
+ for (KeyframeEffect* effect : m_effects)
sof 2015/09/03 05:21:46 Aren't you touching a heap object here? And how a
+ effect->notifyElementDestroyed();
+ m_effects.clear();
+#endif
}
void ElementAnimations::updateAnimationFlags(ComputedStyle& style)
@@ -88,6 +93,9 @@ DEFINE_TRACE(ElementAnimations)
visitor->trace(m_cssAnimations);
visitor->trace(m_defaultStack);
visitor->trace(m_animations);
+#if !ENABLE(OILPAN)
+ visitor->trace(m_effects);
+#endif
}
const ComputedStyle* ElementAnimations::baseComputedStyle() const
« no previous file with comments | « Source/core/animation/ElementAnimations.h ('k') | Source/core/animation/KeyframeEffect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698