Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Source/core/animation/ElementAnimations.h

Issue 1322883003: Oilpan: KeyframeEffect::m_target shouldn't become stale (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/animation/ElementAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/ElementAnimations.h
diff --git a/Source/core/animation/ElementAnimations.h b/Source/core/animation/ElementAnimations.h
index fc6b4827600b99effca611d166d2a9e7b0388d3f..b8054e1c38fd9d5be45ebbe608562ead2294985c 100644
--- a/Source/core/animation/ElementAnimations.h
+++ b/Source/core/animation/ElementAnimations.h
@@ -74,6 +74,11 @@ public:
void updateBaseComputedStyle(const ComputedStyle*);
void clearBaseComputedStyle();
+#if !ENABLE(OILPAN)
+ void addEffect(KeyframeEffect* effect) { m_effects.add(effect); }
+ void dispose();
+#endif
+
DECLARE_TRACE();
private:
@@ -85,6 +90,12 @@ private:
bool m_animationStyleChange;
RefPtr<ComputedStyle> m_baseComputedStyle;
+#if !ENABLE(OILPAN)
+ // TODO(oilpan): This is to avoid a reference cycle that keeps Elements
+ // alive and won't be needed once the Node hierarchy becomes traceable.
+ HeapHashSet<WeakMember<KeyframeEffect>> m_effects;
+#endif
+
// CSSAnimations and DeferredLegacyStyleInterpolation checks if a style change is due to animation.
friend class CSSAnimations;
friend class DeferredLegacyStyleInterpolation;
« no previous file with comments | « no previous file | Source/core/animation/ElementAnimations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698