Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322843002: Fix for rotate from 0deg (Closed)

Created:
5 years, 3 months ago by Eric Willigers
Modified:
5 years, 3 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, loyso (OOO), rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix for rotate from 0deg This patch causes rotate to use numerical interpolation when either from or to angle is 0deg. The axis of rotation used will be the axis that has a non-zero angle. If both from and to axis are both zero, then the default (0, 0, 1) axis is used. Patch by soonm@google.com BUG=516577 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201583

Patch Set 1 #

Total comments: 10

Patch Set 2 : pause #

Patch Set 3 : no rotational symmetry #

Total comments: 2

Patch Set 4 : remove redundant div #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3 lines) Patch
M LayoutTests/animations/interpolation/rotate-interpolation.html View 2 chunks +26 lines, -1 line 0 comments Download
A LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees.html View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M Source/platform/transforms/RotateTransformOperation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Eric Willigers
5 years, 3 months ago (2015-09-01 00:42:47 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/1322843002/diff/1/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html File LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html (right): https://codereview.chromium.org/1322843002/diff/1/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html#newcode19 LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html:19: <div id="target"></div> No need for target as it will ...
5 years, 3 months ago (2015-09-01 01:48:46 UTC) #3
Eric Willigers
https://codereview.chromium.org/1322843002/diff/1/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees.html File LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees.html (right): https://codereview.chromium.org/1322843002/diff/1/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees.html#newcode22 LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees.html:22: expected.style.rotate = '225deg 1 0 0'; On 2015/09/01 01:48:46, ...
5 years, 3 months ago (2015-09-01 06:24:42 UTC) #4
Eric Willigers
Updated. https://codereview.chromium.org/1322843002/diff/1/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html File LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html (right): https://codereview.chromium.org/1322843002/diff/1/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html#newcode19 LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html:19: <div id="target"></div> On 2015/09/01 01:48:46, alancutter wrote: > ...
5 years, 3 months ago (2015-09-01 06:32:10 UTC) #5
alancutter (OOO until 2018)
lgtm with nit. https://codereview.chromium.org/1322843002/diff/40001/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html File LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html (right): https://codereview.chromium.org/1322843002/diff/40001/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html#newcode17 LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html:17: <div id="expected"></div> Redundant div.
5 years, 3 months ago (2015-09-01 06:46:23 UTC) #6
Eric Willigers
noel: request platform owners review https://codereview.chromium.org/1322843002/diff/40001/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html File LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html (right): https://codereview.chromium.org/1322843002/diff/40001/LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html#newcode17 LayoutTests/virtual/threaded/animations/compositor-rotate-zero-degrees-expected.html:17: <div id="expected"></div> On 2015/09/01 ...
5 years, 3 months ago (2015-09-01 07:56:17 UTC) #7
Noel Gordon
On 2015/09/01 07:56:17, Eric Willigers wrote: > noel: request platform owners review LGTM
5 years, 3 months ago (2015-09-01 10:50:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322843002/60001
5 years, 3 months ago (2015-09-01 21:49:35 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:18:16 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201583

Powered by Google App Engine
This is Rietveld 408576698