Issue 132283008: Don't link gtest into sandbox lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132283008: Don't link gtest into sandbox lib (Closed)

Created:
6 years, 10 months ago by scottmg

Modified:
6 years, 10 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't link gtest into sandbox lib I contend we probably don't want to ship gtest? R=jschuh@chromium.org BUG=329384 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247657

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	sandbox/win/sandbox_win.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/132283008/1

6 years, 10 months ago (2014-01-29 04:04:48 UTC) #3

commit-bot: I haz the power

Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=110385

6 years, 10 months ago (2014-01-29 05:05:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/132283008/1

6 years, 10 months ago (2014-01-29 05:12:54 UTC) #6

Message was sent while issue was closed.

Change committed as 247657

Expand Messages | Collapse Messages