DescriptionRevert of Cast: Fix threading issues in VideoEncoderImpl (https://codereview.chromium.org/138953009/)
Reason for revert:
build break.
Original issue's description:
> Cast: Fix threading issues in VideoEncoderImpl
>
> VideoEncoderImpl can be used after delete. We assumed that main thread
> out-live video encoder thread. This is not true for some use cases. For
> example in the renderer when video encoder thread is shared by multiple
> instances of CastSEnder. To fix this we need to separate Vp8Encoder and
> VideoEncoderImpl.
>
> VideoEncoderImpl will live on the main thread only. And Vp8Encoder will
> live on the video encoder thread only.
>
> Tested this change with vagrind and cast_unittests reports no error.
>
> TBR=mikhal@chromium.org
> BUG=336887
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246974
TBR=mikhal@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336887
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246986
Patch Set 1 #
Created: 6 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|