Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 132283006: Revert of Cast: Fix threading issues in VideoEncoderImpl (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
Reviewers:
mikhal1
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Revert of Cast: Fix threading issues in VideoEncoderImpl (https://codereview.chromium.org/138953009/) Reason for revert: build break. Original issue's description: > Cast: Fix threading issues in VideoEncoderImpl > > VideoEncoderImpl can be used after delete. We assumed that main thread > out-live video encoder thread. This is not true for some use cases. For > example in the renderer when video encoder thread is shared by multiple > instances of CastSEnder. To fix this we need to separate Vp8Encoder and > VideoEncoderImpl. > > VideoEncoderImpl will live on the main thread only. And Vp8Encoder will > live on the video encoder thread only. > > Tested this change with vagrind and cast_unittests reports no error. > > TBR=mikhal@chromium.org > BUG=336887 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246974 TBR=mikhal@chromium.org NOTREECHECKS=true NOTRY=true BUG=336887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -139 lines) Patch
M media/cast/test/end2end_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/cast/video_sender/codecs/vp8/vp8_encoder.h View 3 chunks +0 lines, -8 lines 0 comments Download
M media/cast/video_sender/codecs/vp8/vp8_encoder.cc View 7 chunks +12 lines, -24 lines 0 comments Download
M media/cast/video_sender/video_encoder_impl.h View 3 chunks +16 lines, -13 lines 0 comments Download
M media/cast/video_sender/video_encoder_impl.cc View 5 chunks +39 lines, -78 lines 0 comments Download
M media/cast/video_sender/video_encoder_impl_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
Created Revert of Cast: Fix threading issues in VideoEncoderImpl
6 years, 11 months ago (2014-01-24 22:26:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/132283006/1
6 years, 11 months ago (2014-01-24 22:29:11 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 22:31:26 UTC) #3
Message was sent while issue was closed.
Change committed as 246986

Powered by Google App Engine
This is Rietveld 408576698