Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 132283002: Modify --log-net-log comment to remove option for command line output. (Closed)

Created:
6 years, 11 months ago by Randy Smith (Not in Mondays)
Modified:
6 years, 11 months ago
Reviewers:
mmenke, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Modify --log-net-log comment to remove option for command line output. BUG=None R=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244204

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/public/common/content_switches.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Randy Smith (Not in Mondays)
Matt:?
6 years, 11 months ago (2014-01-09 17:51:03 UTC) #1
mmenke
Tiny nit: CL descriptions usually use present tense. https://codereview.chromium.org/132283002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/132283002/diff/1/content/public/common/content_switches.cc#newcode695 content/public/common/content_switches.cc:695: // ...
6 years, 11 months ago (2014-01-09 17:55:24 UTC) #2
mmenke
Oh, and LGTM - feel free either to follow or disregard my comments.
6 years, 11 months ago (2014-01-09 17:55:53 UTC) #3
Randy Smith (Not in Mondays)
Both done; thanks! https://codereview.chromium.org/132283002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/132283002/diff/1/content/public/common/content_switches.cc#newcode695 content/public/common/content_switches.cc:695: // those events. On 2014/01/09 17:55:25, ...
6 years, 11 months ago (2014-01-09 18:35:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/132283002/70001
6 years, 11 months ago (2014-01-09 18:40:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44105
6 years, 11 months ago (2014-01-09 19:07:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/132283002/70001
6 years, 11 months ago (2014-01-09 20:22:44 UTC) #7
Randy Smith (Not in Mondays)
joi@chromium.org: Please stamp? I hadn't realized that content_switches.* needed owners approval, but clearly I was ...
6 years, 11 months ago (2014-01-09 20:23:15 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44140
6 years, 11 months ago (2014-01-09 21:06:18 UTC) #9
Jói
LGTM, and for content_switches a TBR is generally fine.
6 years, 11 months ago (2014-01-10 11:20:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/132283002/70001
6 years, 11 months ago (2014-01-10 15:20:49 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 18:19:22 UTC) #12
Message was sent while issue was closed.
Change committed as 244204

Powered by Google App Engine
This is Rietveld 408576698