Fix OSK to show when physical keyboard is detached on KK

Fix OSK to show when physical keyboard is detached on KK

On KK, the same object is passed and we do not detect keyboard
change correctly.

BUG=500662
Committed: https://crrev.com/85255cdcd8787a564e117ebd4991ce1975659b69
Cr-Commit-Position: refs/heads/master@{#346810}

[Changwan Ryu, 2015-08-31 06:17:56]

changwan@chromium.org changed reviewers:
+ aelias@chromium.org, jdduke@chromium.org

[jdduke (slow), 2015-08-31 15:07:30]

On 2015/08/31 06:17:56, Changwan Ryu wrote:

lgtm, how difficult would it be to add a regression test here? Wouldn't want
somebody to come in and "clean" it up.

[Changwan Ryu, 2015-09-01 07:29:16]

On 2015/08/31 15:07:30, jdduke wrote:
> On 2015/08/31 06:17:56, Changwan Ryu wrote:
> 
> lgtm, how difficult would it be to add a regression test here? Wouldn't want
> somebody to come in and "clean" it up.

Added a test and changed implementation. PTAL.

[jdduke (slow), 2015-09-01 15:40:45]

jdduke@chromium.org changed reviewers:
+ yfriedman@chromium.org

[jdduke (slow), 2015-09-01 15:40:45]

lgtm, thanks for the test.

+yfriedman for contnet/public/test/android.

https://codereview.chromium.org/1322793002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/1322793002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1618:
mCurrentConfig = new Configuration(newConfig);
Can you add a short comment as to why we don't store |newConfig|?

https://codereview.chromium.org/1322793002/diff/20001/content/public/test/and...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
(right):

https://codereview.chromium.org/1322793002/diff/20001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java:120:
public int getHideSoftInputCounter() {
I'll let the javadoc slide for consistency with the surrounding code :)

[Yaron, 2015-09-01 18:31:19]

lgtm

[Changwan Ryu, 2015-09-02 00:04:35]

https://codereview.chromium.org/1322793002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/1322793002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1618:
mCurrentConfig = new Configuration(newConfig);
On 2015/09/01 15:40:45, jdduke wrote:
> Can you add a short comment as to why we don't store |newConfig|?

Done.

https://codereview.chromium.org/1322793002/diff/20001/content/public/test/and...
File
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
(right):

https://codereview.chromium.org/1322793002/diff/20001/content/public/test/and...
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java:120:
public int getHideSoftInputCounter() {
On 2015/09/01 15:40:45, jdduke wrote:
> I'll let the javadoc slide for consistency with the surrounding code :)

Done.

[Changwan Ryu, 2015-09-02 00:04:40]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-09-02 00:04:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jdduke@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1322793002/#ps40001
(title: "added comments and javadocs")

[commit-bot: I haz the power, 2015-09-02 00:04:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322793002/40001

[commit-bot: I haz the power, 2015-09-02 01:08:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-02 01:09:06]

Patchset 3 (id:??) landed as
https://crrev.com/85255cdcd8787a564e117ebd4991ce1975659b69
Cr-Commit-Position: refs/heads/master@{#346810}

[aelias_OOO_until_Jul13, 2015-10-01 22:31:52]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1377103004/ by aelias@chromium.org.

The reason for reverting is: Causes http://crbug.com/534666, and the real fix
https://codereview.chromium.org/1362603002 seems like it probably won't land
before 47 branch point.  Revert this for now to make 47 match 46..