Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 132273002: Speculative fix for OOM on win ninja builders (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
Nico, robertshield
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Speculative fix for OOM on win ninja builders Bots failing with FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True sync_performance_tests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 link.exe /nologo /OUT:sync_performance_tests.exe @sync_performance_tests.exe.rsp" 1 mt.exe rc.exe "obj\chrome\sync_performance_tests.sync_performance_tests.exe.intermediate.manifest" obj\chrome\sync_performance_tests.sync_performance_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest LINK : fatalerror LNK1102: out of memory Attempted speculative global fix to see if this helps. R=robertshield@chromium.org TBR=robertshield@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1833

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
robertshield
lgtm
6 years, 11 months ago (2014-01-09 17:39:49 UTC) #1
scottmg
Committed patchset #1 manually as r1833 (presubmit successful).
6 years, 11 months ago (2014-01-09 17:40:52 UTC) #2
Nico
https://codereview.chromium.org/132273002/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://codereview.chromium.org/132273002/diff/1/pylib/gyp/generator/ninja.py#newcode1561 pylib/gyp/generator/ninja.py:1561: # TODO(scottmg): Temporary speculative fix for OOM on builders ...
6 years, 11 months ago (2014-01-09 20:22:00 UTC) #3
scottmg
6 years, 11 months ago (2014-01-09 20:29:35 UTC) #4
Message was sent while issue was closed.
On 2014/01/09 20:22:00, Nico wrote:
> https://codereview.chromium.org/132273002/diff/1/pylib/gyp/generator/ninja.py
> File pylib/gyp/generator/ninja.py (right):
> 
>
https://codereview.chromium.org/132273002/diff/1/pylib/gyp/generator/ninja.py...
> pylib/gyp/generator/ninja.py:1561: # TODO(scottmg): Temporary speculative fix
> for OOM on builders
> tracking bug for doing this right?

crbug.com/333000 (and updated comment here)

Powered by Google App Engine
This is Rietveld 408576698