Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1322703003: [turbofan] Include individual deferred block ranges in splintering. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Include individual deferred block ranges in splintering. While we may have consecutive deferred blocks, they may be entered from other blocks that are not predecessors of the first block. Same for the last block and exiting. So the total set of live ranges within the given set of blocks is the union of the individual in and out live sets. This is a performance bug, not a functional bug. BUG= Committed: https://crrev.com/5fc253a8057f65fa6866cc03bd116a4e76ed214d Cr-Commit-Position: refs/heads/master@{#30564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/compiler/live-range-separator.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322703003/1
5 years, 3 months ago (2015-09-03 09:39:41 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-03 09:39:43 UTC) #4
Mircea Trofin
5 years, 3 months ago (2015-09-03 09:49:55 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322703003/1
5 years, 3 months ago (2015-09-03 12:56:01 UTC) #8
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-03 12:56:03 UTC) #10
Jarin
lgtm
5 years, 3 months ago (2015-09-03 13:58:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322703003/1
5 years, 3 months ago (2015-09-03 13:59:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 14:00:43 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 14:00:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fc253a8057f65fa6866cc03bd116a4e76ed214d
Cr-Commit-Position: refs/heads/master@{#30564}

Powered by Google App Engine
This is Rietveld 408576698