Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: ui/views/bubble/bubble_delegate_unittest.cc

Issue 13227002: Revise NativeWidgetWin focus hack; force focus on restore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update test comment. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/bubble/bubble_delegate.h" 5 #include "ui/views/bubble/bubble_delegate.h"
6 #include "ui/views/bubble/bubble_frame_view.h" 6 #include "ui/views/bubble/bubble_frame_view.h"
7 #include "ui/views/test/test_widget_observer.h" 7 #include "ui/views/test/test_widget_observer.h"
8 #include "ui/views/test/views_test_base.h" 8 #include "ui/views/test/views_test_base.h"
9 #include "ui/views/widget/widget.h" 9 #include "ui/views/widget/widget.h"
10 10
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 169 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
170 scoped_ptr<Widget> anchor_widget(new Widget); 170 scoped_ptr<Widget> anchor_widget(new Widget);
171 anchor_widget->Init(params); 171 anchor_widget->Init(params);
172 anchor_widget->Show(); 172 anchor_widget->Show();
173 173
174 TestBubbleDelegateView* bubble_delegate = 174 TestBubbleDelegateView* bubble_delegate =
175 new TestBubbleDelegateView(anchor_widget->GetContentsView()); 175 new TestBubbleDelegateView(anchor_widget->GetContentsView());
176 Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate); 176 Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate);
177 bubble_widget->Show(); 177 bubble_widget->Show();
178 178
179 View* expected_view = bubble_delegate->GetInitiallyFocusedView(); 179 EXPECT_EQ(bubble_delegate->GetInitiallyFocusedView(),
180 // TODO(ben|msw): The NativeWidgetWin::RestoreFocusOnActivate() workaround for 180 bubble_widget->GetFocusManager()->GetFocusedView());
181 // http://crbug.com/125976 breaks this simple test by clearing proper focus.
182 #if defined(OS_WIN) && !defined(USE_AURA)
183 expected_view = NULL;
184 #endif
185
186 EXPECT_EQ(expected_view, bubble_widget->GetFocusManager()->GetFocusedView());
187 bubble_widget->CloseNow(); 181 bubble_widget->CloseNow();
188 } 182 }
189 183
190 } // namespace views 184 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698