Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322673003: Do not run GC in ScriptPromisePropertyBase::destroyContext(). (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
sof
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not run GC in ScriptPromisePropertyBase::destroyContext(). Discussion: https://codereview.chromium.org/1306083008/ BUG=526608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201544

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 4 chunks +9 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yhirano
5 years, 3 months ago (2015-08-31 08:20:49 UTC) #2
yhirano
webkit_unit_tests pass on all bots.
5 years, 3 months ago (2015-08-31 08:21:15 UTC) #3
sof
lgtm % no leaks. https://codereview.chromium.org/1322673003/diff/1/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp File Source/bindings/core/v8/ScriptPromisePropertyTest.cpp (right): https://codereview.chromium.org/1322673003/diff/1/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp#newcode357 Source/bindings/core/v8/ScriptPromisePropertyTest.cpp:357: Property* property = this->property(); not ...
5 years, 3 months ago (2015-08-31 08:44:03 UTC) #4
yhirano
https://codereview.chromium.org/1322673003/diff/1/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp File Source/bindings/core/v8/ScriptPromisePropertyTest.cpp (right): https://codereview.chromium.org/1322673003/diff/1/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp#newcode357 Source/bindings/core/v8/ScriptPromisePropertyTest.cpp:357: Property* property = this->property(); On 2015/08/31 08:44:03, sof wrote: ...
5 years, 3 months ago (2015-09-01 07:01:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322673003/20001
5 years, 3 months ago (2015-09-01 09:32:09 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:37:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201544

Powered by Google App Engine
This is Rietveld 408576698