Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 132263003: sync: fix tiny bug with NotificationServiceSessionsRouter (Closed)

Created:
6 years, 11 months ago by tim (not reviewing)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

sync: fix tiny bug with NotificationServiceSessionsRouter On Chrome os managed mode, if we get a blocked navigation before session sync is set up we can't do anything with it. BUG=98892 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/sync/sessions2/notification_service_sessions_router.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tim (not reviewing)
Nicolas, please review. Bernhard FYI.
6 years, 11 months ago (2014-01-09 19:01:32 UTC) #1
Nicolas Zea
lgtm
6 years, 11 months ago (2014-01-09 19:54:11 UTC) #2
Bernhard Bauer
lgtm
6 years, 11 months ago (2014-01-09 19:57:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/132263003/1
6 years, 11 months ago (2014-01-09 20:44:27 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 22:28:22 UTC) #5
Message was sent while issue was closed.
Change committed as 244001

Powered by Google App Engine
This is Rietveld 408576698