Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1322623007: [turbofan] Optimize Splinter by remembering where it left off. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize Splinter by remembering where it left off. Splintering relies on DetachAt, which in turn relies on FirstSearchIntervalForPosition to find the first UseInterval to split, given a position. The later API (Find...) has an optimization for linear traversals. Splintering traverses linearly (block by block), so we leverage the same optimization by moving current_interval_ forward. (Also added an unrelated TODO.) BUG=chromium:524880 LOG=n Committed: https://crrev.com/1d9642d37fdbbd27d12c3ba99e96912447ce78e0 Cr-Commit-Position: refs/heads/master@{#30456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/compiler/register-allocator.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-28 21:50:38 UTC) #2
Benedikt Meurer
LGTM.
5 years, 3 months ago (2015-08-31 06:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322623007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322623007/1
5 years, 3 months ago (2015-08-31 06:39:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 07:06:13 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 07:06:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d9642d37fdbbd27d12c3ba99e96912447ce78e0
Cr-Commit-Position: refs/heads/master@{#30456}

Powered by Google App Engine
This is Rietveld 408576698