Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: Source/core/loader/LinkHeaderTest.cpp

Issue 1322543003: Fix Link header parsing bug with extension parameter parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed valid char to match the spec Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/loader/LinkHeader.h" 6 #include "core/loader/LinkHeader.h"
7 7
8 #include <base/macros.h> 8 #include <base/macros.h>
9 #include <gtest/gtest.h> 9 #include <gtest/gtest.h>
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 struct DoubleTestCase { 102 struct DoubleTestCase {
103 const char* headerValue; 103 const char* headerValue;
104 const char* url; 104 const char* url;
105 const char* rel; 105 const char* rel;
106 bool valid; 106 bool valid;
107 const char* url2; 107 const char* url2;
108 const char* rel2; 108 const char* rel2;
109 bool valid2; 109 bool valid2;
110 } cases[] = { 110 } cases[] = {
111 {"<ybg.css>; rel=stylesheet, <simple.css>; rel=stylesheet", "ybg.css", " stylesheet", true, "simple.css", "stylesheet", true}, 111 {"<ybg.css>; rel=stylesheet, <simple.css>; rel=stylesheet", "ybg.css", " stylesheet", true, "simple.css", "stylesheet", true},
112 {"<ybg.css>; rel=stylesheet,<simple.css>; rel=stylesheet", "ybg.css", "s tylesheet", true, "simple.css", "stylesheet", true},
113 {"<ybg.css>; rel=stylesheet;crossorigin,<simple.css>; rel=stylesheet", " ybg.css", "stylesheet", true, "simple.css", "stylesheet", true},
112 }; 114 };
113 115
114 for (auto& testCase : cases) { 116 for (auto& testCase : cases) {
115 LinkHeaderSet headerSet(testCase.headerValue); 117 LinkHeaderSet headerSet(testCase.headerValue);
116 LinkHeader& header1 = headerSet[0]; 118 LinkHeader& header1 = headerSet[0];
117 LinkHeader& header2 = headerSet[1]; 119 LinkHeader& header2 = headerSet[1];
118 ASSERT_STREQ(testCase.url, header1.url().ascii().data()); 120 ASSERT_STREQ(testCase.url, header1.url().ascii().data());
119 ASSERT_STREQ(testCase.rel, header1.rel().ascii().data()); 121 ASSERT_STREQ(testCase.rel, header1.rel().ascii().data());
120 ASSERT_EQ(testCase.valid, header1.valid()); 122 ASSERT_EQ(testCase.valid, header1.valid());
121 ASSERT_STREQ(testCase.url2, header2.url().ascii().data()); 123 ASSERT_STREQ(testCase.url2, header2.url().ascii().data());
122 ASSERT_STREQ(testCase.rel2, header2.rel().ascii().data()); 124 ASSERT_STREQ(testCase.rel2, header2.rel().ascii().data());
123 ASSERT_EQ(testCase.valid2, header2.valid()); 125 ASSERT_EQ(testCase.valid2, header2.valid());
124 } 126 }
125 } 127 }
126 128
127 TEST(LinkHeaderTest, CrossOrigin) 129 TEST(LinkHeaderTest, CrossOrigin)
128 { 130 {
129 struct TestCase { 131 struct TestCase {
130 const char* headerValue; 132 const char* headerValue;
131 const char* url; 133 const char* url;
132 const char* rel; 134 const char* rel;
133 const CrossOriginAttributeValue crossorigin; 135 const CrossOriginAttributeValue crossorigin;
134 bool valid; 136 bool valid;
135 } cases[] = { 137 } cases[] = {
136 {"<http://whatever.com>; rel=preconnect", "http://whatever.com", "precon nect", CrossOriginAttributeNotSet, true}, 138 {"<http://whatever.com>; rel=preconnect", "http://whatever.com", "precon nect", CrossOriginAttributeNotSet, true},
137 {"<http://whatever.com>; rel=preconnect; crossorigin=", "http://whatever .com", "preconnect", CrossOriginAttributeAnonymous, true}, 139 {"<http://whatever.com>; rel=preconnect; crossorigin=", "http://whatever .com", "preconnect", CrossOriginAttributeAnonymous, true},
138 {"<http://whatever.com>; rel=preconnect; crossorigin", "http://whatever. com", "preconnect", CrossOriginAttributeAnonymous, true}, 140 {"<http://whatever.com>; rel=preconnect; crossorigin", "http://whatever. com", "preconnect", CrossOriginAttributeAnonymous, true},
141 {"<http://whatever.com>; rel=preconnect; crossorigin;", "http://whatever .com", "preconnect", CrossOriginAttributeAnonymous, true},
142 {"<http://whatever.com>; rel=preconnect; crossorigin, <http://whatever2. com>; rel=preconnect", "http://whatever.com", "preconnect", CrossOriginAttribute Anonymous, true},
143 {"<http://whatever.com>; rel=preconnect; crossorigin,<http://whatever2.c om>; rel=preconnect", "http://whatever.com", "preconnect", CrossOriginAttributeA nonymous, true},
139 {"<http://whatever.com>; rel=preconnect; crossorigin=anonymous", "http:/ /whatever.com", "preconnect", CrossOriginAttributeAnonymous, true}, 144 {"<http://whatever.com>; rel=preconnect; crossorigin=anonymous", "http:/ /whatever.com", "preconnect", CrossOriginAttributeAnonymous, true},
140 {"<http://whatever.com>; rel=preconnect; crossorigin=use-credentials", " http://whatever.com", "preconnect", CrossOriginAttributeUseCredentials, true}, 145 {"<http://whatever.com>; rel=preconnect; crossorigin=use-credentials", " http://whatever.com", "preconnect", CrossOriginAttributeUseCredentials, true},
141 {"<http://whatever.com>; rel=preconnect; crossorigin=whatever", "http:// whatever.com", "preconnect", CrossOriginAttributeAnonymous, true}, 146 {"<http://whatever.com>; rel=preconnect; crossorigin=whatever", "http:// whatever.com", "preconnect", CrossOriginAttributeAnonymous, true},
142 }; 147 };
143 148
144 149
145 // Test the cases with a single header 150 // Test the cases with a single header
146 for (auto& testCase : cases) { 151 for (auto& testCase : cases) {
147 LinkHeaderSet headerSet(testCase.headerValue); 152 LinkHeaderSet headerSet(testCase.headerValue);
148 LinkHeader& header = headerSet[0]; 153 LinkHeader& header = headerSet[0];
149 ASSERT_STREQ(testCase.url, header.url().ascii().data()); 154 ASSERT_STREQ(testCase.url, header.url().ascii().data());
150 ASSERT_STREQ(testCase.rel, header.rel().ascii().data()); 155 ASSERT_STREQ(testCase.rel, header.rel().ascii().data());
151 ASSERT_EQ(testCase.crossorigin, header.crossOrigin()); 156 ASSERT_EQ(testCase.crossorigin, header.crossOrigin());
152 ASSERT_EQ(testCase.valid, header.valid()); 157 ASSERT_EQ(testCase.valid, header.valid());
153 } 158 }
154 } 159 }
155 } // namespace blink 160 } // namespace blink
OLDNEW
« Source/core/loader/LinkHeader.cpp ('K') | « Source/core/loader/LinkHeader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698