build/config/BUILDCONFIG.gn - Issue 1322523008: Modify the gcc_toolchain definitions in GN for NaCl compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1322523008: Modify the gcc_toolchain definitions in GN for NaCl compatibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_cleanup

Patch Set: update w/ review comments, remove post_solink reference Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index c91db167b34dcc8adcd98dab2e09835599b89727..6bc28eccf710cf6e6b2f40609d1a79b7ef67837b 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -415,7 +415,7 @@ if (is_linux) {

_native_compiler_configs += [ "//build/config/android:sdk" ]

}

-if (is_clang) {

+if (is_clang && !is_nacl) {

_native_compiler_configs += [

"//build/config/clang:find_bad_constructs",

"//build/config/clang:extra_warnings",

« no previous file with comments | « no previous file | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »