[heap] Make compaction space accept external memory.

[heap] Make compaction space accept external memory.

BUG=chromium:524425
LOG=N

Committed: https://crrev.com/4ecf07daa3d0a6081679b788f0cfd7e16fe62064
Cr-Commit-Position: refs/heads/master@{#30428}

[Michael Lippautz, 2015-08-27 18:23:47]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-08-27 18:23:47]

https://codereview.chromium.org/1322523004/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (left):

https://codereview.chromium.org/1322523004/diff/1/src/heap/spaces.cc#oldcode2222
src/heap/spaces.cc:2222: DCHECK_LE(FreeList::kSmallListMin, size_in_bytes);
kSmallListMin is now private (as all other constants). There's an if at the top
of FreeList::Free that ensures size_in_bytes > FreeList::kSmallListMin.

https://codereview.chromium.org/1322523004/diff/1/src/heap/spaces.h
File src/heap/spaces.h (left):

https://codereview.chromium.org/1322523004/diff/1/src/heap/spaces.h#oldcode1646
src/heap/spaces.h:1646: static const int kSmallListMax = 0xff * kPointerSize;
Decl sorting.

[Hannes Payer (out of office), 2015-08-27 18:30:41]

cool, lgtm

https://codereview.chromium.org/1322523004/diff/1/test/cctest/test-spaces.cc
File test/cctest/test-spaces.cc (right):

https://codereview.chromium.org/1322523004/diff/1/test/cctest/test-spaces.cc#...
test/cctest/test-spaces.cc:444: TEST(CompactionSpaceUsingExternal) {
CompactionSpaceUsingExternalMemory

[Michael Lippautz, 2015-08-27 18:37:48]

https://codereview.chromium.org/1322523004/diff/1/test/cctest/test-spaces.cc
File test/cctest/test-spaces.cc (right):

https://codereview.chromium.org/1322523004/diff/1/test/cctest/test-spaces.cc#...
test/cctest/test-spaces.cc:444: TEST(CompactionSpaceUsingExternal) {
On 2015/08/27 18:30:40, Hannes Payer (OOO) wrote:
> CompactionSpaceUsingExternalMemory

Done.

[Michael Lippautz, 2015-08-27 18:38:20]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-27 18:38:21]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1322523004/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2015-08-27 18:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322523004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322523004/20001

[Michael Lippautz, 2015-08-27 18:45:13]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-27 18:45:13]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1322523004/#ps40001
(title: "intptr_t -> int")

[commit-bot: I haz the power, 2015-08-27 18:45:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322523004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322523004/40001

[commit-bot: I haz the power, 2015-08-27 18:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 18:55:40]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Michael Lippautz, 2015-08-27 19:04:14]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-27 19:04:14]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1322523004/#ps60001
(title: "intptr/int troubles")

[commit-bot: I haz the power, 2015-08-27 19:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322523004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322523004/60001

[Michael Lippautz, 2015-08-27 19:14:26]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-27 19:14:26]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1322523004/#ps80001
(title: "Properly free spaces and allocator")

[commit-bot: I haz the power, 2015-08-27 19:14:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322523004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322523004/80001

[commit-bot: I haz the power, 2015-08-27 20:31:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-27 20:32:17]

Patchset 5 (id:??) landed as
https://crrev.com/4ecf07daa3d0a6081679b788f0cfd7e16fe62064
Cr-Commit-Position: refs/heads/master@{#30428}